From owner-freebsd-current@freebsd.org Wed Sep 4 14:47:06 2019
Return-Path: <owner-freebsd-current@freebsd.org>
Delivered-To: freebsd-current@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
by mailman.nyi.freebsd.org (Postfix) with ESMTP id A14B8F3E84
for <freebsd-current@mailman.nyi.freebsd.org>;
Wed, 4 Sep 2019 14:47:06 +0000 (UTC)
(envelope-from gljennjohn@gmail.com)
Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org
[IPv6:2610:1c1:1:606c::50:13])
by mx1.freebsd.org (Postfix) with ESMTP id 46Nmqt28phz4PfV
for <freebsd-current@freebsd.org>; Wed, 4 Sep 2019 14:47:06 +0000 (UTC)
(envelope-from gljennjohn@gmail.com)
Received: by mailman.nyi.freebsd.org (Postfix)
id 49F10F3E83; Wed, 4 Sep 2019 14:47:06 +0000 (UTC)
Delivered-To: current@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
by mailman.nyi.freebsd.org (Postfix) with ESMTP id 49B36F3E82
for <current@mailman.nyi.freebsd.org>; Wed, 4 Sep 2019 14:47:06 +0000 (UTC)
(envelope-from gljennjohn@gmail.com)
Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com
[IPv6:2a00:1450:4864:20::444])
(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
server-signature RSA-PSS (4096 bits)
client-signature RSA-PSS (2048 bits) client-digest SHA256)
(Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK))
by mx1.freebsd.org (Postfix) with ESMTPS id 46Nmqt0z3kz4PfT;
Wed, 4 Sep 2019 14:47:05 +0000 (UTC)
(envelope-from gljennjohn@gmail.com)
Received: by mail-wr1-x444.google.com with SMTP id y8so21566710wrn.10;
Wed, 04 Sep 2019 07:47:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to
:mime-version:content-transfer-encoding;
bh=KrSfoD9x8citdH9v32eQhdiF+nUokk2cYQsUgp5ZdXU=;
b=k5XfYGiZ9Ri5kqrN2m98yAPpdTkSKg+sjb8qrKQ4yr6OdLlLPtGtujsyD/FwEn5dAp
EygWmp06paDjM2rt37nVrzCQHBJqSbSUw5fJcNfyGt3IAdjoH4SZaehHh2hesYbSsGiE
DNxeVbEW93XLlAOZLI8zJghyJ0UvQOWyBTl2QZcjr5Y3jJ+7Dm5xBqxHTEon89S8wBPu
PC2+2OEhkUeWFK4/X32fSnMaRn00k6jdTR0hVDcBxf5uQjCnAw/Bf4QXf1SwGy/KYcRy
12/YlUcSeiH2AIgKp/B5Opv8TN5jqfdMEiYV3DKRyrvC0TUnHNISFl455FhHHKSetNk4
eZrw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
:references:reply-to:mime-version:content-transfer-encoding;
bh=KrSfoD9x8citdH9v32eQhdiF+nUokk2cYQsUgp5ZdXU=;
b=Xmu0PHjr+Xi3nyfG+mtlO0XsuKDnpcYa/amdEiVO0zgZ5XZHUFH4o93GZrt7Z2BqD0
VNc1tIIN+O57i5AGSZF50eMBGOhUMVJ2EGeDc5ix9I2TJZrpDXW5DegI/rAmukq8H+ck
ZJilbdKAOsopCaCke+Bh9WjgqB7RkbTDLdp3wJtmQHZtALV57tPux/zIIxRoeI/zpEaH
r6ld4ECimhPDZsgiIgFwcWHcmfgmdpGdH8XosGVPW6hqka2iOwPZErZQITz/y4t5Wit7
0tUOYBR9UZhMzik24cWdVCeePOnV6u/1to5kFDo+5qFy4k3GUcqevqE24A0tpg6SPFAt
Ub0g==
X-Gm-Message-State: APjAAAVu6D9nn7Q0W9IrtKhjpOSvkyJ5uetsvnWdgSW5GaOngmfADAui
FDDtwmznPe9ws/btC8eh11lC1/DE
X-Google-Smtp-Source: APXvYqwOhrUOLdK8FitYFImfSa/lJizbVSlaLuLeAQBj7m1B0zM75BRGopS8wI1asSvT0C+K2fY6vA==
X-Received: by 2002:adf:fac1:: with SMTP id a1mr51224483wrs.56.1567608424401;
Wed, 04 Sep 2019 07:47:04 -0700 (PDT)
Received: from ernst.home (p5B0234B9.dip0.t-ipconnect.de. [91.2.52.185])
by smtp.gmail.com with ESMTPSA id a192sm4357780wma.1.2019.09.04.07.47.03
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 04 Sep 2019 07:47:03 -0700 (PDT)
Date: Wed, 4 Sep 2019 16:47:01 +0200
From: Gary Jennejohn <gljennjohn@gmail.com>
To: Kyle Evans <kevans@freebsd.org>
Cc: Enji Cooper <yaneurabeya@gmail.com>, Poul-Henning Kamp
<phk@phk.freebsd.dk>, current <current@freebsd.org>
Subject: Re: Weird goings on with make::empty()
Message-ID: <20190904164701.7b4ab5bf@ernst.home>
In-Reply-To: <CACNAnaE7Gw=r92akmx=tXgGNb=H7GuKm7=iXX2cLtSAxNALikA@mail.gmail.com>
References: <3843.1567598344@critter.freebsd.dk>
<969A062A-A52A-49E3-B4E3-CC9377B08C80@gmail.com>
<CACNAnaE7Gw=r92akmx=tXgGNb=H7GuKm7=iXX2cLtSAxNALikA@mail.gmail.com>
Reply-To: gljennjohn@gmail.com
X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; amd64-portbld-freebsd13.0)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Rspamd-Queue-Id: 46Nmqt0z3kz4PfT
X-Spamd-Bar: ------
Authentication-Results: mx1.freebsd.org;
none
X-Spamd-Result: default: False [-6.98 / 15.00];
NEURAL_HAM_MEDIUM(-1.00)[-0.998,0];
NEURAL_HAM_SHORT(-0.98)[-0.979,0];
NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
<freebsd-current.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-current>,
<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-current>,
<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Sep 2019 14:47:06 -0000
On Wed, 4 Sep 2019 09:33:08 -0500
Kyle Evans <kevans@freebsd.org> wrote:
> On Wed, Sep 4, 2019 at 9:27 AM Enji Cooper <yaneurabeya@gmail.com> wrote:
> >
> >
> > > On Sep 4, 2019, at 04:59, Poul-Henning Kamp <phk@phk.freebsd.dk> wrote:
> > >
> > > On:
> > >
> > > Repository Root: svn+ssh://repo.freebsd.org/base
> > > Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
> > > Revision: 351809
> > >
> > > I built a kernel, but drm-current-kmod did not get compiled
> > > from the new world order in /usr/local/sys/modules
> > >
> > > Debugging I ended up doing this to src/sys/conf/kern.post.mk:
> > >
> > > Index: sys/conf/kern.post.mk
> > > ===================================================================
> > > --- sys/conf/kern.post.mk (revision 351809)
> > > +++ sys/conf/kern.post.mk (working copy)
> > > @@ -77,12 +77,14 @@
> > > ${target:S/^reinstall$/install/:S/^clobber$/cleandir/}
> > > .endif
> > > .for module in ${LOCAL_MODULES}
> > > -.if !empty(module)
> > > + true "XXX A $(module) 2 ${LOCALBASE} 3 ${LOCAL_MODULES} 4 ${MODULES_WITH_WORLD}"
> > > +#.if !empty(module)
> > > + true "XXX B $(module) 2 ${LOCALBASE} 3 ${LOCAL_MODULES} 4 ${MODULES_WITH_WORLD}"
> > > @${ECHODIR} "===> ${module} (${target:S/^reinstall$/install/:S/^clobber$/cleandir/})"
> > > @cd ${LOCAL_MODULES_DIR}/${module}; ${MKMODULESENV} ${MAKE} \
> > > DIRPRFX="${module}/" \
> > > ${target:S/^reinstall$/install/:S/^clobber$/cleandir/}
> > > -.endif
> > > +#.endif
> > > .endfor
> > > .endif
> > > .endfor
> > >
> > > This gives me the expected output from buildkernel:
> > >
> > > true "XXX A drm-current-kmod 2 /usr/local 3 drm-current-kmod 4 "
> > > true "XXX B drm-current-kmod 2 /usr/local 3 drm-current-kmod 4 "
> > >
> > > If I leave in the ".if !empty(module)" line in, I only get:
> > >
> > > true "XXX A drm-current-kmod 2 /usr/local 3 drm-current-kmod 4 "
> > >
> > > suggestions welcome...
> >
> > (CCing Kyle)
> >
> > This behavior change is probably caused by r351799.
> >
> > I personally think the code before Kyle___s change and after it was buggy. It___s not word splitting LOCAL_MODULES before iterating over it.
> >
>
> I've backed out r351799 since it breaks usage of LOCAL_MODULES (though
> I really don't understand how empty works, apparently, and that makes
> me sad)... please advise on a correct path forward, because it's not
> clear to me.
>
In Kyle's defence my testing of his patch was only with
LOCAL_MODULES= and LOCAL_MODULES="" in /etc/src.conf. I don't
have any ports modules to be compiled with the kernel.
--
Gary Jennejohn