From nobody Tue Sep 6 19:32:15 2022 X-Original-To: freebsd-ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MMbBB3mttz4bW84 for ; Tue, 6 Sep 2022 19:32:18 +0000 (UTC) (envelope-from bofh@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MMbBB3Kc0z3fpj; Tue, 6 Sep 2022 19:32:18 +0000 (UTC) (envelope-from bofh@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662492738; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DVv7nuZsV2QB1UEauL+AOA0c5Zodo7crYoWcWGq+v0k=; b=Oj9/RiMH809PEU3Nb9TW+cKxdxtD2y4jqnOnwDJEagJO4WvC062hMO2GNSf4ptowOtJs15 cv/LN64Z8STl/6+yKu9B5XTAJLlQZO60XbB65ZDkMAdcKwDYNbI1HJOGrsEbdKnY1I6HvD ha/XmR3kI9DX3xdyLhPCXXoLnGbaOD2TBohDbJYIRdbmFVMEXgdFjpoiEdPPArv9VQikmw ohDxRK4mFj9/85leoRwGR6kMPfnf6VNXwOUZE6f73FC2mKSMgnAmidkpVopwjTlPBv+U/K 51Q24l5Y9ajsSflPV81fstlw5vfX1SYcmTivOd6nXifpn1eJ98iG6V0BITIBdQ== Received: from mx.bofh.network (mx.bofh.network [IPv6:2a0d:2787:2::28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.bofh.network", Issuer "R3" (verified OK)) (Authenticated sender: bofh/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4MMbB96KGmz10l7; Tue, 6 Sep 2022 19:32:17 +0000 (UTC) (envelope-from bofh@FreeBSD.org) Received: from [10.40.55.97] (89-20-161-102.static.ef-service.nl [89.20.161.102]) by mx.bofh.network (OpenSMTPD) with ESMTPSA id 10824603 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 6 Sep 2022 19:32:16 +0000 (UTC) Message-ID: Date: Tue, 6 Sep 2022 21:32:15 +0200 List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: HEADS-UP: Upcoming move of WWW definitions in all ports Content-Language: en-US To: Stefan Esser , sgk@troutmask.apl.washington.edu Cc: FreeBSD ports , portmgr References: <8a896af9-b41e-d939-c71c-3b0b6b8366b6@FreeBSD.org> <16ecf008-56db-a553-97cc-6183e56674a4@FreeBSD.org> From: Moin Rahman In-Reply-To: <16ecf008-56db-a553-97cc-6183e56674a4@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662492738; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DVv7nuZsV2QB1UEauL+AOA0c5Zodo7crYoWcWGq+v0k=; b=bWYf/5Q77Mawgl8Ej5uR9tzD1+buSPrWHP6DottahgL+WLzv02P3bciG92vpE03zgPyX6E R+lX9PC5S//iAlFe2kHZqU/FnNCqtpmXaZpx2MDDhOFO7JoXDhoiDXwSvhBeuyrorRKwXk WImBlhc7wG3rF9P8UXk5sUnQC8PAMLq2wF7AwEWZBjLFcBFGRy3vDYfy8n7pLJpJ4fJp9M Nxuyf36HOEiZO4KahNbCdChxj1uhGIFicCuPv9NZdWOvQCVnoiodB/JrRY5l/DFVNAEbrH HO7jv/UHrqhlPO/gARB/5YLEXsl8GvOVWFGcOVUfnSIXQJUJnIDghGWFVBElTQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1662492738; a=rsa-sha256; cv=none; b=XjXQEr5ZAiW+2hUNlh6khJsagFdFJ9jNvyp3x5jp/04UtiBBxesnPPQxbzh2iVaJTtyqHG /d1e/eveFESYka+/GtymmNjEXDdjoknoQPzZxLnUFS2kKtPKaphH7R2ShB+2Rdh9qtg6Vt Ks1YNxXIsbtWf5s9IRTH9CTZ984ecpKJzoWKZjraYGIiwZg15FyzFPn5KGSDqR06njHC2S WahG4VZnPbBsu44gyLon4bL4B5Qqfnw6ytlbWZB9KTnrYUIU7i2yWoMjjaGx8E/0OOZwXk Y8dioBTqoRVUIpb0Ly/w7dwt/Qjc3zheDrYEanpGHk+e1dBGmFh6xqAzuOfUxw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 9/6/22 9:04 PM, Stefan Esser wrote: > Am 06.09.22 um 20:31 schrieb Steve Kargl: >> On Tue, Sep 06, 2022 at 08:09:24PM +0200, Stefan Esser wrote: >>> PortMgr has just accepted a change that has been in the making for >>> some time: >>> >>> The move of the "WWW:" entries at the end of the ports' pkg-descr >>> files into >>> the ports' Makefiles in the form of "WWW=" definitions. >>> >>> The WWW lines will be put into the maintainer block, immediately >>> following >>> the MAINTAINER and COMMENT lines. >>> >>> If there is more than one WWW: line a pkg-descr file, one URL will be >>> selected to be moved into the Makefile, the other URLs will get a label >>> "See also:" instead of "WWW:". >>> >> >> You've told us the "What" and suggested a "When".  So, what is >> the "Why?" >> >> % find . -name pkg-descr -maxdepth 3 | wc -l >>     29110 >> % find . -name Makefile -maxdepth 3 | wc -l >>     30343 >> >> Assuming 90% of the files are touched, 54000 files suffering cosmetic >> churn? > > The idea to move the WWW entry from the pkg-descr to the Makefile has > come up > multiple times in the past, back in 2015 for the first time that I know of, > see https://reviews.freebsd.org/D2949. It's really interesting to see my work being resurrected after nearly 7 years. But yeah thanks for the hard work and I believe my task was easier than what you are doing or did. I believe you or portmgr@ has a better script to complete the task. In case you are planning to use my script I would advise doing in batches per category so far from my experience. But then again I believe there are more competent ones than me to take care of this. :D > The question whether the churn caused by commits to 2 files of nearly > all ports > has been discussed within the PortMgr team for some time. The decision > to go > ahead has now been made, after all prerequisites have been met. > > > The WWW field is the only parameter in the INDEX file or in package > manifests > that is not derived from some variable in the ports' Makefiles. > > It has become stale in quite a number of ports over time, one reason > might be > that the pkg-descr files are seldom touched after the initial commit. > And many > of the URLs did not follow the rules laid out in the porters' handbook. > > The most relevant WWW: entry in each pkg-descr file should be in the > last line > (if there are multiple WWW: lines) and this line is currently extracted > using > awk when the INDEX is built. But in fact, many ports have the relevant > URL in > some other line and thus do not get any useful URL in the INDEX. > > Moving the WWW value into the Makefile will make it easier to maintain > and test > whether it is still valid. It removes processing overhead from "make > index" and > it is a chance to select the most relevant entry from multiple URLs in > many of > the pkg-descr files. > > Best regards, STefan >