From owner-cvs-all@FreeBSD.ORG Tue Mar 30 12:32:15 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B3E2A16A4CE; Tue, 30 Mar 2004 12:32:15 -0800 (PST) Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1AE0843D1F; Tue, 30 Mar 2004 12:32:15 -0800 (PST) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.10/8.12.9) with ESMTP id i2UKWDkj012792; Tue, 30 Mar 2004 13:32:14 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Tue, 30 Mar 2004 13:32:25 -0700 (MST) Message-Id: <20040330.133225.67033839.imp@bsdimp.com> To: nate@root.org From: "M. Warner Losh" In-Reply-To: <20040330104458.J81785@root.org> References: <20040325234024.GJ26131@elvis.mu.org> <20040325.171634.59655793.imp@bsdimp.com> <20040330104458.J81785@root.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: wpaul@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/compat/ndis kern_ndis.c subr_ndis.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Mar 2004 20:32:16 -0000 In message: <20040330104458.J81785@root.org> Nate Lawson writes: : On Thu, 25 Mar 2004, M. Warner Losh wrote: : > In message: <20040325234024.GJ26131@elvis.mu.org> : > Alfred Perlstein writes: : > : * M. Warner Losh [040325 14:11] wrote: : > : > In message: : > : > des@des.no (Dag-Erling Sm?rgrav) writes: : > : > : Bill Paul writes: : > : > : : > : > : des@dwp ~% gf BUS_GET_RESOURCE_LIST : > : > : qsrc/sys/compat/ndis/kern_ndis.c: brl = BUS_GET_RESOURCE_LIST(device_get_parent(dev), dev); : > : > : src/sys/dev/if_ndis/if_ndis_pci.c: rl = BUS_GET_RESOURCE_LIST(device_get_parent(dev), dev); : > : > : src/sys/kern/subr_bus.c: rl = BUS_GET_RESOURCE_LIST(dev, child); : > : > : src/sys/kern/subr_bus.c: rl = BUS_GET_RESOURCE_LIST(dev, child); : > : > : src/sys/kern/subr_bus.c: rl = BUS_GET_RESOURCE_LIST(dev, child); : > : > : src/sys/kern/subr_bus.c: rl = BUS_GET_RESOURCE_LIST(dev, child); : > : > : src/sys/kern/subr_bus.c: rl = BUS_GET_RESOURCE_LIST(dev, child); : > : > : > : > Acutally, there are alot of downstream users of rl. : > : : > : :( : > : : > : Shouldn't we have macros: : > : : > : BUS_GET_RESOURCE_NEXT ? : > : : > : (instead of SLIST_NEXT) : > : > We already do. bus_generic_rl_get_resource, et al. The problem here : > is that the pci bus never intended its resources to be exposed outside : > of the bus layer. But windows drivers need it, so there needs to be : > some tweaks need to be made. : > : > It looks like I was incorrect about the downstream uses of it. I : > thought that pci and pccard did that, but it appears that they now use : > the common functions that matt dodd moved into subr_bus a while ago. : : Fixing this to be FIFO instead of LIFO would also have helped for floppy : devices that specified a 6-port resource as three 2-port resources. When : put in LIFO order, this gave 5-6,3-4,1-2 instead of 1-2,3-4,5-6. The : latter would have been easier to parse. I'll look at dealing... Warner