Date: Sat, 23 Mar 2019 04:32:10 +0000 (UTC) From: Cy Schubert <cy@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r345437 - head/libexec/rc/rc.d Message-ID: <201903230432.x2N4WAg9005763@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: cy Date: Sat Mar 23 04:32:10 2019 New Revision: 345437 URL: https://svnweb.freebsd.org/changeset/base/345437 Log: The check for $ippool_rules in start_cmd is tautological. Reported by: hrs@ MFC after: 13 days X-MFC with: r345400 Modified: head/libexec/rc/rc.d/ippool Modified: head/libexec/rc/rc.d/ippool ============================================================================== --- head/libexec/rc/rc.d/ippool Sat Mar 23 03:37:08 2019 (r345436) +++ head/libexec/rc/rc.d/ippool Sat Mar 23 04:32:10 2019 (r345437) @@ -14,19 +14,16 @@ name="ippool" desc="user interface to the IPFilter pools" rcvar="ippool_enable" load_rc_config $name -start_cmd="ippool_start" +start_precmd="ippool_start_precmd" stop_cmd="${ippool_program} -F" reload_cmd="ippool_reload" extra_commands="reload" required_files="${ippool_rules}" required_modules="ipl:ipfilter" -ippool_start() +ippool_start_precmd() { - if [ -r "${ippool_rules}" ]; then - echo "Loading IP Pools." - ${ippool_program} -f ${ippool_rules} ${ippool_flags} - fi + rc_flags="-f ${ippool_rules} ${rc_flags}" } ippool_reload()
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201903230432.x2N4WAg9005763>