From owner-svn-src-head@freebsd.org Thu Feb 20 15:35:03 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2E08023CB3F; Thu, 20 Feb 2020 15:35:03 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48NdvB4v0rz4dxB; Thu, 20 Feb 2020 15:35:02 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from [192.168.0.3] (unknown [181.52.72.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: pfg) by smtp.freebsd.org (Postfix) with ESMTPSA id 280A3F340; Thu, 20 Feb 2020 15:35:01 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Subject: Re: svn commit: r358153 - head/usr.sbin/services_mkdb To: Ed Maste Cc: Li-Wen Hsu , Xin LI , Yuri Pankov , src-committers , svn-src-all , svn-src-head References: <202002200354.01K3s8ib077553@repo.freebsd.org> <48DC2EEA-22D6-4A0D-84CE-3F0770962DB3@yuripv.me> <17cf5f33-309d-5bba-dde8-bd85ce0ba191@FreeBSD.org> From: Pedro Giffuni Organization: FreeBSD Message-ID: Date: Thu, 20 Feb 2020 10:35:00 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Feb 2020 15:35:03 -0000 On 20/02/2020 10:09, Ed Maste wrote: > On Thu, 20 Feb 2020 at 09:54, Pedro Giffuni wrote: >> On 2020-02-20 09:46, Ed Maste wrote: >>> On Thu, 20 Feb 2020 at 04:56, Li-Wen Hsu wrote: >>>> Please note this is not fixed in ci.freebsd.org yet. The reason is it >>>> directly goes to src/release and perform `make packagesystem` to >>>> generate kernel.txz and base.txz. If I read release(7) correctly, >>>> this should be performed under a fresh installed environment. I am >>>> checking how to fix this. >>> Should we revert the change until a build fix can be committed too? >> I am OK with reverting the change, and I am rather surprised such a >> simply change could have broken the build. > Indeed, this has uncovered a broken dependency in our build process > (i.e., that the build host's services_mkdb is being used). > > IMO we should: > > 1. Revert the change for now (pfg will you take care of it?) Yes, Give me some minutes ... > 2. MFC the MAX_PROTO increase as soon as possible > 3. Try to fix the use of host's services_mkdb > 4. Recommit after either #3 is done, or FreeBSD 12.2 and 11.4 are released Pedro.