From owner-freebsd-wireless@freebsd.org Mon May 21 20:35:14 2018 Return-Path: Delivered-To: freebsd-wireless@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BC366EFDB00 for ; Mon, 21 May 2018 20:35:14 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-wr0-x22e.google.com (mail-wr0-x22e.google.com [IPv6:2a00:1450:400c:c0c::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3044A6F28E for ; Mon, 21 May 2018 20:35:14 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-wr0-x22e.google.com with SMTP id r13-v6so4891438wrj.10 for ; Mon, 21 May 2018 13:35:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UQMqkxeK7OKjkkCuYaRvAoEQTkz5Y9ONSV8LWnNkS+U=; b=W7HWMJgXu4W+EblWgCN4oO9/VgDdIU1UrfnVgq5VI8yietGabpeBOjcXRz/6Y2+86X Bcs24U6Qcm4MXG0EM7173Zd+oP0d9XpCuoD1qYtxOP9oBhs7lLXDjtviRTLK8fxtgrsh 4PG4PSEZxSjfvVwBpIr3FJjmzJrEIEf/cVQWyk9O+5UC/D/hVB3DyF/9vmRCrsANL1Qx FwOQBtMdSo2b+iKdsvpGzgT4221TxKkN8xVh4xK8yQYMIuZPzbx1r+zBaJex9yiterr6 Ezx4AdLQafnfKq8UZ0Cn5AzusGZtb5KufkLYFWoI+xTJ+Em2pKTF73kylrjoCjlk+dQE Fz4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UQMqkxeK7OKjkkCuYaRvAoEQTkz5Y9ONSV8LWnNkS+U=; b=Nk7NpQuINURaY8/1w1ZpJ8YGdNoqWf2GQtGY7rMbKFQ5FXwYU/cBmfOhI0LndyVPEE QyKJYSlgUJ3wOnxxWOs51NylVGW3Oa8Qlv50rN9JOIR3xADKADbkAbgOXQIF3Jvgnu71 /OxVU4eb9p5wmKyzeeBiManNTE1blWWJTyT1y50o9arXa+n0h0wVKIAg4lD1Azlip2Fd YIssjQonzh0kCpyNB6qegZq/W4f3csjuXoP/jGHvGIZntsqgvaJ3Mlm3UnuJSMsEAtSi KN/ApbPnWhK4kGHqnuJgSf7mzH79A3VOjXDdlKjLLWpWOyQm8Prqh4eZqfOc7BFXWjZF /cJg== X-Gm-Message-State: ALKqPwdkLBT+e1qVgOq9EOLN/HIH8yi2IqLCug0yJ8W0VyBbE2h/Wwr7 ORNMU9tCFuF2ojZHKChMXgjtBFTQ7WwaR8nxrQqi6w== X-Google-Smtp-Source: AB8JxZrTE9ZP3yyO93cUsoeyFesZY3AbFCC8UZM1ptK+MWF9eWayF7Bv4jYbVhqu/CqzhTGJVUy9WmxMFD2omHPN2t0= X-Received: by 2002:adf:a00d:: with SMTP id k13-v6mr16146754wrk.39.1526934913104; Mon, 21 May 2018 13:35:13 -0700 (PDT) MIME-Version: 1.0 References: <20180502165745.59a5bfc4@bigbox.christie.dr> <20180502211001.550d290c@bigbox.christie.dr> <20180503192743.639240d0@bigbox.christie.dr> <20180504005448.GA89012@bluezbox.com> <20180506201659.0a831f5f@bigbox.christie.dr> <20180521140745.65243721@bigbox.christie.dr> In-Reply-To: <20180521140745.65243721@bigbox.christie.dr> From: Adrian Chadd Date: Mon, 21 May 2018 13:34:58 -0700 Message-ID: Subject: Re: ath0: could not map interrupt (again?) To: freebsd@tim.thechases.com Cc: Oleksandr Tymoshenko , "freebsd-wireless@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 May 2018 20:35:15 -0000 hi, warner says "pcie interrupts aren't shared." :-) So why is this working? You're saying this is a mini-pci slot? Would you please file a PR so we can get some more eyeballs on this? thanks! -adrian On Mon, 21 May 2018 at 12:55, Tim Chase wrote: > I've been using this for a couple weeks now with no issues, for what > little value my OK is, your patch seems to be ready to roll. > -tim > On 2018-05-06 20:16, Tim Chase wrote: > > On 2018-05-03 17:54, Oleksandr Tymoshenko wrote: > > > Tim Chase (freebsd@tim.thechases.com) wrote: > > > > ppb0 at pci0 dev 28 function 0 "Intel SCH PCIE" rev 0x07: apic 2 > > > > int 17 ... > > > > athn0 at pci2 dev 0 function 0 "Atheros AR9281" rev 0x01: apic 2 > > > > int 17 athn0: AR9280 rev 2 (2T2R), ROM rev 22, address > > > > 00:24:d2:b3:8c:b4 > > > > > > > > so it looks like the interrupt *can* be shared, it just appears > > > > that FreeBSD is doing something peculiar with it. > > > > > > It looks like PCI bridge allocates interupt without RF_SHAREABLE > > > (see dev/pci/pci_pci.c, pcib_alloc_pcie_irq). Could you test > > > this patch [1]? I am not sure if non-shareable IRQs for PCI/PCI > > > bridge is a design decision or it's just that nobody has hit this > > > problem before. > > > > > > [1] > > > https://people.freebsd.org/~gonzo/patches/pci_pci-shareable-irq.diff > > > > Applying your one-line patch adding RF_SHAREABLE (sorry for the > > delay as buildworld took ~2.5 days and buildkernel took about half > > a day on this machine) does seem to have at least gotten past the > > initial issue. The pcib1 now looks like it's properly sharing the > > interrupt and ath0 at least identifies. Relevant excerpts from > > dmesg: > > > > # dmesg | grep -e ath0 -e pcib1 > > pcib1: irq 17 at device 28.0 on pci0 > > pcib1: [GIANT-LOCKED] > > pci1: on pcib1 > > ath0: mem 0xd8000000-0xd800ffff irq 17 at device 0.0 > > on pci2 ath0: [HT] enabling HT modes > > ath0: [HT] 1 stream STBC receive enabled > > ath0: [HT] 1 stream STBC transmit enabled > > ath0: [HT] 2 RX streams; 2 TX streams > > ath0: AR9280 mac 128.2 RF5133 phy 13.0 > > ath0: 2GHz radio: 0x0000; 5GHz radio: 0x00c0 > > > > This was performed against HEAD which, at the time, was r333254. > > > > I'll poke at it more thoroughly in the morning, but I wanted to let > > you know that it seems to be working thus far. > > > > If you know of any particular ways in which I should stress it (to > > see if IRQ 17 on pcib1 really *wasn't* supposed to be sharable), I'd > > be glad to abuse it a bit. > > > > Many thanks! > > > > -tim > > > > > > > > > _______________________________________________ > freebsd-wireless@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-wireless > To unsubscribe, send any mail to "freebsd-wireless-unsubscribe@freebsd.org "