From nobody Tue Sep 6 19:36:51 2022 X-Original-To: freebsd-ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MMbHV1dGKz4bWtS for ; Tue, 6 Sep 2022 19:36:54 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "troutmask", Issuer "troutmask" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MMbHT4WbQz3hv8; Tue, 6 Sep 2022 19:36:53 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.16.1/8.16.1) with ESMTPS id 286Japdj008791 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Tue, 6 Sep 2022 12:36:51 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.16.1/8.16.1/Submit) id 286JapDP008790; Tue, 6 Sep 2022 12:36:51 -0700 (PDT) (envelope-from sgk) Date: Tue, 6 Sep 2022 12:36:51 -0700 From: Steve Kargl To: Stefan Esser Cc: FreeBSD ports , portmgr Subject: Re: HEADS-UP: Upcoming move of WWW definitions in all ports Message-ID: Reply-To: sgk@troutmask.apl.washington.edu References: <8a896af9-b41e-d939-c71c-3b0b6b8366b6@FreeBSD.org> <16ecf008-56db-a553-97cc-6183e56674a4@FreeBSD.org> List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16ecf008-56db-a553-97cc-6183e56674a4@FreeBSD.org> X-Rspamd-Queue-Id: 4MMbHT4WbQz3hv8 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=washington.edu (policy=none); spf=none (mx1.freebsd.org: domain of sgk@troutmask.apl.washington.edu has no SPF policy when checking 128.95.76.21) smtp.mailfrom=sgk@troutmask.apl.washington.edu X-Spamd-Result: default: False [-2.99 / 15.00]; NEURAL_HAM_LONG(-1.00)[-0.998]; NEURAL_HAM_SHORT(-1.00)[-0.996]; NEURAL_HAM_MEDIUM(-0.99)[-0.993]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[washington.edu : No valid SPF, No valid DKIM,none]; MLMMJ_DEST(0.00)[freebsd-ports@freebsd.org]; R_SPF_NA(0.00)[no SPF record]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; ASN(0.00)[asn:73, ipnet:128.95.0.0/16, country:US]; RCVD_TLS_LAST(0.00)[]; R_DKIM_NA(0.00)[]; TO_DN_ALL(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; REPLYTO_ADDR_EQ_FROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; HAS_REPLYTO(0.00)[sgk@troutmask.apl.washington.edu] X-ThisMailContainsUnwantedMimeParts: N On Tue, Sep 06, 2022 at 09:04:10PM +0200, Stefan Esser wrote: > Am 06.09.22 um 20:31 schrieb Steve Kargl: > > On Tue, Sep 06, 2022 at 08:09:24PM +0200, Stefan Esser wrote: > > > PortMgr has just accepted a change that has been in the making for some time: > > > > > > The move of the "WWW:" entries at the end of the ports' pkg-descr files into > > > the ports' Makefiles in the form of "WWW=" definitions. > > > > > > The WWW lines will be put into the maintainer block, immediately following > > > the MAINTAINER and COMMENT lines. > > > > > > If there is more than one WWW: line a pkg-descr file, one URL will be > > > selected to be moved into the Makefile, the other URLs will get a label > > > "See also:" instead of "WWW:". > > > > > > > You've told us the "What" and suggested a "When". So, what is > > the "Why?" > > > > % find . -name pkg-descr -maxdepth 3 | wc -l > > 29110 > > % find . -name Makefile -maxdepth 3 | wc -l > > 30343 > > > > Assuming 90% of the files are touched, 54000 files suffering cosmetic churn? > > The idea to move the WWW entry from the pkg-descr to the Makefile has come up > multiple times in the past, back in 2015 for the first time that I know of, > see https://reviews.freebsd.org/D2949. > > The question whether the churn caused by commits to 2 files of nearly all ports > has been discussed within the PortMgr team for some time. The decision to go > ahead has now been made, after all prerequisites have been met. > > > The WWW field is the only parameter in the INDEX file or in package manifests > that is not derived from some variable in the ports' Makefiles. > > It has become stale in quite a number of ports over time, one reason might be > that the pkg-descr files are seldom touched after the initial commit. And many > of the URLs did not follow the rules laid out in the porters' handbook. > > The most relevant WWW: entry in each pkg-descr file should be in the last line > (if there are multiple WWW: lines) and this line is currently extracted using > awk when the INDEX is built. But in fact, many ports have the relevant URL in > some other line and thus do not get any useful URL in the INDEX. > > Moving the WWW value into the Makefile will make it easier to maintain and test > whether it is still valid. It removes processing overhead from "make index" and > it is a chance to select the most relevant entry from multiple URLs in many of > the pkg-descr files. > Thanks for the explanation. I had assumed that there was some motivation, but lacking acccess to the port-mgr mail archive makes it somewhat difficult to find the information. -- Steve