From owner-svn-src-head@freebsd.org Fri Sep 1 21:46:12 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 434C2E08E74; Fri, 1 Sep 2017 21:46:12 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from d.mail.sonic.net (d.mail.sonic.net [64.142.111.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 11BED64FBC; Fri, 1 Sep 2017 21:46:11 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from aurora.physics.berkeley.edu (aurora.physics.berkeley.edu [128.32.117.67]) (authenticated bits=0) by d.mail.sonic.net (8.15.1/8.15.1) with ESMTPSA id v81LZFLa020584 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Fri, 1 Sep 2017 14:35:16 -0700 Subject: Re: svn commit: r323087 - in head/sys: amd64/conf arm64/conf i386/conf powerpc/conf riscv/conf sparc64/conf To: Ian Lepore , cem@freebsd.org, Josh Paetzel Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201709011554.v81FssRG083114@repo.freebsd.org> <1504284895.41612.29.camel@freebsd.org> From: Nathan Whitehorn Message-ID: <4c48a573-d6d6-9f2f-3034-e265e5fdfe99@freebsd.org> Date: Fri, 1 Sep 2017 14:35:15 -0700 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1504284895.41612.29.camel@freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Sonic-CAuth: UmFuZG9tSVYZgzevPAykMyNDNectW5SjcXwkkWK4hlOJ8MoaEbBWRw4dKl95+M2+6LhsM3fPMrxtKgonU3EM+rlHLLzzyujoVA6hOLSojnI= X-Sonic-ID: C;3reLcV2P5xGx2/sKk0eh0A== M;LOzHcV2P5xGx2/sKk0eh0A== X-Spam-Flag: No X-Sonic-Spam-Details: 0.0/5.0 by cerberusd X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Sep 2017 21:46:12 -0000 On 09/01/17 09:54, Ian Lepore wrote: > On Fri, 2017-09-01 at 09:06 -0700, Conrad Meyer wrote: >> Wait, why? The PR doesn't explain it any better than this commit >> message. >> >> On Fri, Sep 1, 2017 at 8:54 AM, Josh Paetzel >> wrote: >>> Author: jpaetzel >>> Date: Fri Sep 1 15:54:53 2017 >>> New Revision: 323087 >>> URL: https://svnweb.freebsd.org/changeset/base/323087 >>> >>> Log: >>> Take options IPSEC out of GENERIC >>> >>> PR: 220170 >>> Submitted by: delphij >>> Reviewed by: ae, glebius >>> MFC after: 2 weeks >>> Differential Revision: D11806 > The differential revision (which should be cited using the complete url > in the commit) seems to indicate that it's because it can be kldloaded. > > This change misses the armv6 platform, where the option appears in > std.armv6, which gets included in GENERIC (and all other armv6 > configs). > > This change seems to warrant an entry in UPDATING, because it's going > to catch a lot of people by surprise. Even people with custom kernels, > if they follow the advice of the handbook and "include GENERIC" then > override things. > > -- Ian > I realize this is immediately moot because the commit has been reverted, but please remember about powerpc/conf/GENERIC64 for future such changes. This is the "GENERIC" kernel for the powerpc64 architecture, which does not have its own arch directory. -Nathan