From owner-svn-src-all@FreeBSD.ORG Sun Apr 5 17:16:16 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3B532B53; Sun, 5 Apr 2015 17:16:16 +0000 (UTC) Received: from mail-pd0-x234.google.com (mail-pd0-x234.google.com [IPv6:2607:f8b0:400e:c02::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 04FA12B1; Sun, 5 Apr 2015 17:16:16 +0000 (UTC) Received: by pdbnk13 with SMTP id nk13so21073234pdb.0; Sun, 05 Apr 2015 10:16:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:mime-version:in-reply-to:content-type :content-transfer-encoding:message-id:cc:from:subject:date:to; bh=bUkZBgLbuWhCkNFci1Jf8+JEXHrJBTyIpe+J2A6JjHI=; b=oaPcaT6KR41SHnoaDw5Bsf+iPr6yw8P9aY9pKssbYKTl3EPpMKQ3HlGuMAZFrgHgV0 GwXYs7H8QxH86kP8QGXM2pXS6LYqZIKFzxbIHF2t3SMivRjuIghsvr6HLLoCk2neCqWJ 6d6soexkYqBdKjETcyKCRaciymZaj3f8x1PJm3hX2ev+mT5MGazTbc4+sQk1LPHkVoFW 6BlX5tc9qaHp/1MvPTIEk1Z7fe8mTT7RWsPUSoAL42KXGFARmgQBbTKzwhk/QHAF5HZm jXD+gakSgIAk6gZw+8pnH8yv7QCZPT+WDOAP3+7tYdKGaYQCtwspXiAZZro4h+5Ox+En oJ2A== X-Received: by 10.68.102.228 with SMTP id fr4mr20822713pbb.87.1428254175498; Sun, 05 Apr 2015 10:16:15 -0700 (PDT) Received: from [10.22.190.54] (mobile-166-171-249-060.mycingular.net. [166.171.249.60]) by mx.google.com with ESMTPSA id w9sm2035626pdm.89.2015.04.05.10.16.14 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 05 Apr 2015 10:16:14 -0700 (PDT) References: <201504051709.t35H9xG3036827@svn.freebsd.org> Mime-Version: 1.0 (1.0) In-Reply-To: <201504051709.t35H9xG3036827@svn.freebsd.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Message-Id: X-Mailer: iPhone Mail (12D508) From: Garrett Cooper Subject: Re: svn commit: r281112 - head/etc/rc.d Date: Sun, 5 Apr 2015 10:16:09 -0700 To: Josh Paetzel Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Apr 2015 17:16:16 -0000 Hi Josh, > On Apr 5, 2015, at 10:09, Josh Paetzel wrote: >=20 > Author: jpaetzel > Date: Sun Apr 5 17:09:58 2015 > New Revision: 281112 > URL: https://svnweb.freebsd.org/changeset/base/281112 >=20 > Log: > Bug fixes and feature adds >=20 > - Remove extranious echo that breaks puppet > - Handle restarts of multiple pflog devices correctly > - Add the ability to perform actions on specific pflog devices. >=20 > PR: 199150 > Submitted by: jason.unovitch@gmail.com > MFC after: 3 days >=20 > Modified: > head/etc/rc.d/pflog >=20 > Modified: head/etc/rc.d/pflog > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > --- head/etc/rc.d/pflog Sun Apr 5 16:35:13 2015 (r281111) > +++ head/etc/rc.d/pflog Sun Apr 5 17:09:58 2015 (r281112) > @@ -24,30 +24,30 @@ pflog_prestart() > { > load_kld pflog || return 1 >=20 > + # create pflog_dev interface if needed > + if ! ifconfig $pflog_dev > /dev/null 2>&1; then > + if ! ifconfig $pflog_dev create; then > + warn "could not create $pflog_dev." > + return 1 > + fi > + fi Is a character device created for pflog? > + > # set pflog_dev interface to up state > if ! ifconfig $pflog_dev up; then > warn "could not bring up $pflog_dev." > return 1 > fi >=20 > + # -p flag requires striping pidfile's leading /var/run and trailing .= pid > + pidfile=3D$(echo $pidfile | sed -e 's|/var/run/||' -e 's|.pid$||') > + Could this use pgrep with a custom pidfile? Thanks!=