From nobody Tue Sep 6 20:26:26 2022 X-Original-To: freebsd-ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MMcNj3pcFz4bcJf for ; Tue, 6 Sep 2022 20:26:29 +0000 (UTC) (envelope-from se@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MMcNj36dRz3qck; Tue, 6 Sep 2022 20:26:29 +0000 (UTC) (envelope-from se@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662495989; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SUNt0o5wkCZOAKzhKTlOcv0r4qdvt9qjfdVD+OSFDRQ=; b=bZJTSth3wNll/U+j66F85Ok2RShjdrIC63IPFTIPXkjguCAaIlBR/F6TyfbZ1yOchLwvaw XHx7wrBRpRmbioxspPwgRat3WRWb4iYXpd/6hBP8pNcQZy4rSuFQH/0gXlUZ66u/0cAiba ksWLTmvnqUuDeYg+v1iOBs+W1DVhAHKAe6aohRYczfU70wYGvt4hYErM4zWZ8AkojDhvWW qkiZ7MgaF9pqC0AQuFXxbnO5lCi8GsUOAtv0QZrIEYNmdRWYlAyBDNcSndKrsETSoxStZu 5/u/4JGp7OSAiqOItOpHdwNIOScIH7P92YNktnPn2u1L40qNBDiypGLmXiGE4g== Received: from [IPV6:2003:cd:5f1e:4500:409:67d5:fb35:f281] (p200300cd5f1e4500040967d5fb35f281.dip0.t-ipconnect.de [IPv6:2003:cd:5f1e:4500:409:67d5:fb35:f281]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: se/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4MMcNh5GwVz11P1; Tue, 6 Sep 2022 20:26:28 +0000 (UTC) (envelope-from se@freebsd.org) Message-ID: <835945d1-2a64-8f71-6a52-be2553b4fe71@FreeBSD.org> Date: Tue, 6 Sep 2022 22:26:26 +0200 List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 From: Stefan Esser Subject: Re: HEADS-UP: Upcoming move of WWW definitions in all ports Content-Language: de-DE, en-US To: Moin Rahman Cc: FreeBSD ports , portmgr References: <8a896af9-b41e-d939-c71c-3b0b6b8366b6@FreeBSD.org> <16ecf008-56db-a553-97cc-6183e56674a4@FreeBSD.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662495989; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SUNt0o5wkCZOAKzhKTlOcv0r4qdvt9qjfdVD+OSFDRQ=; b=lAoKHvwCmX38fQVKA+QsFGBEBR3MEJn6F0xRI26bF/qlZ5P2ecycERRXDMprj1woMB2e2L mcdpnOhRVVTIAqqsPXPBSgjTnNHqTBXxjlAn2NYfmVX7O3eN4wbNkTrVN6ekIt6F6zf5zf ASUxXP+nxAk2LKMNrmbsnwK30OHTJQk679CqH7FR8rcCet02CzV+t6apfbM4BbAL752k+D BfGTjZ4AzPyIpqh2Bm0fSUuI+H8N8PkC979PuE1TrgKDkBqRhRLHs3CqW6G/xQyc0wUi/v ke25R4lXbi+Ylkn0+7PeoEGB2P8oE3lSvhw6gzoE7VeLUNyYx0zpRTjbUgQoUQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1662495989; a=rsa-sha256; cv=none; b=VZXYj/aviqQlElagHBDPF/0QMc7HiI+8K5V0jfaoMODleYKcNJGZXh2sJ4W/UIAI9Jcy47 kUGB1EojomlU3fsnPySTsjVhrreIIwPBhqzyJxe49c31qdQLNDqVTT3eh8MCVh96iRoM9u AApWQfhuVDCxMwW7QP4cTFz0Rk9L3TLjJMIzrYANoyfquqaGzKScTCWMU2mK3gR7lzXdbH P2yjlIRpoOJ5Km2LY7R/DAew+Rcj59lH18cNUkaZJuisCzpD2xCJx0kXsf/cC3eLJzN4wH 8FDiQHONAVe/xG4Mrk6+MAVhDCIZtuNJ8ToidAEheE7E1JY/Z4Ax/t/X4VarTw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N Am 06.09.22 um 21:32 schrieb Moin Rahman: > On 9/6/22 9:04 PM, Stefan Esser wrote: [...] >> The idea to move the WWW entry from the pkg-descr to the Makefile has come up >> multiple times in the past, back in 2015 for the first time that I know of, >> see https://reviews.freebsd.org/D2949. > It's really interesting to see my work being resurrected after nearly 7 years. > But yeah thanks for the hard work and I believe my task was easier than what > you are doing or did. I believe you or portmgr@ has a better script to complete > the task. In case you are planning to use my script I would advise doing in > batches per category so far from my experience. But then again I believe there > are more competent ones than me to take care of this. :D This change has been proposed multiple times, and I did not know about your review D2949 when I suggested it to members of the PortMgr team, a few months back. I had prepared a patch to bsd.port.mk, but tcberner was quicker to post his version for review, and I decided to use that as the base of the planned commit. Instead of developing a script to edit each port's Makefile I have just added support for the WWW field to the portlint and portfmt ports - and the portedit script from the latter port will be used to patch the Makefiles. I have discussed the question of whether to commit all files in one go or per category with members of PortMgr, and we have come to the conclusion that it is easier to commit all Makefiles in one commit, followed by one commit for all the pkg-descr files. Else I'd have to worry about intermediate commits and the need to rebase the commits possibly multiple times. And devel alone has 1/4 of all ports, while this is less than the full set, it still would be quite a large commit. Regards, STefan