From nobody Tue Aug 22 21:24:50 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RVj6m0Sv3z4qTNj for ; Tue, 22 Aug 2023 21:25:04 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RVj6l5Dqkz4Lpf for ; Tue, 22 Aug 2023 21:25:03 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2b9c907bc68so82981491fa.2 for ; Tue, 22 Aug 2023 14:25:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20221208.gappssmtp.com; s=20221208; t=1692739502; x=1693344302; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+usIdgICw3E9oJD+43oSdoJyHFn1wFMxjGZC31xELS0=; b=W3q2Kxm2hJU2GaI/vphSXqV0Gbfxkyyh6zpKdOl6SDnqIweCC+6WyXvd7rbL2u6FIL 6Rs0Fvi7eJLKISdWB40d7vvScRCTMSeRvplnFnIULzlBy9CjCV6fbna0P9rdfkCUEZDA ogXZKHGbRBpxDP3Qarv4SNdXhVKD9n23JFFb6M6u0G8OQMTn2OpxO5fPsKar2pvWno4G lznDBoW+58aJhEzO6mdIGz6caZm5aKKkrYilvxHBLDSklIjWMm3UWPBgpxD0jmw+M09I MbYZhhjUApriRF7yHQZL0gX3ioxJK71IdTsUu4A50mVm6yZPBpzwyUFkfaiNLZAHUsGR MWVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692739502; x=1693344302; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+usIdgICw3E9oJD+43oSdoJyHFn1wFMxjGZC31xELS0=; b=IMT8KlvljZJ02mrfArcOK+gmhFxWhl/vIRLEK+SKf8pFBhO5O0onpF708dOl3XmJSZ U1x7UYTdH9GtSsCy4rFg6SLfBm/UayLBLk7sGcJcZKOMVPrTdW05mkh2lJeyIDk0KwyX OIAbKWIlP82d/PpseaVf3DgtDbxjo036pdlP4aC6Y6gDRSUEquuVjnxt/W8aCUlByEMk dEWnwiVZ2puYj8e7DCmk8nUi9dUOh2zutw1oxwW+U/fA0hv6NI4QyzqrUyLy0VlDbpbe mxRLqTc3cA6QVK6Npk/G84iXdMd3eYJmWusFZHemlJBt2aVjxcF60/Xfj7pzL8+gzHpN vBJw== X-Gm-Message-State: AOJu0Yy3DTniNi3MtRcwyM3dL+v8VMxtoxWW1hhtXcI7up64kFzQSSkv ImR6qa9dmueeAkKKETkn7Hnpc13zASwAO0YROzD6ow== X-Google-Smtp-Source: AGHT+IFoJ3SYq2SdQyekbmwB9cEFT1zoJ4zIhOQ9XrNafAVrnwS433UnKSAJn0XT2pAxqv1QaMNczK1IMGsChiyFTnA= X-Received: by 2002:a2e:b707:0:b0:2b9:f1ad:9503 with SMTP id j7-20020a2eb707000000b002b9f1ad9503mr7962021ljo.35.1692739501884; Tue, 22 Aug 2023 14:25:01 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202211042255.2A4MtqVv032693@gitrepo.freebsd.org> <419530F4-DB8F-46EA-BF45-C130BCF8A3DE@FreeBSD.org> <05979953-C089-4D56-99E3-BBBF066FE277@FreeBSD.org> In-Reply-To: <05979953-C089-4D56-99E3-BBBF066FE277@FreeBSD.org> From: Warner Losh Date: Tue, 22 Aug 2023 15:24:50 -0600 Message-ID: Subject: Re: git: 91fcacc35597 - main - if_bnxt: Add support for VLAN on Thor To: Kristof Provost Cc: Warner Losh , Sumit Saxena , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000b52593060389a0ab" X-Rspamd-Queue-Id: 4RVj6l5Dqkz4Lpf X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] --000000000000b52593060389a0ab Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Aug 22, 2023 at 3:07=E2=80=AFPM Kristof Provost wr= ote: > On 27 Jun 2023, at 11:17, Kristof Provost wrote: > > On 4 Nov 2022, at 23:55, Warner Losh wrote: > > The branch main has been updated by imp: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D91fcacc355971f74aa26fc7861020dc= 3a2a2d717 > > commit 91fcacc355971f74aa26fc7861020dc3a2a2d717 > Author: Sumit Saxena > AuthorDate: 2022-11-04 22:24:32 +0000 > Commit: Warner Losh > CommitDate: 2022-11-04 22:24:32 +0000 > > if_bnxt: Add support for VLAN on Thor > > Reviewed by: imp > Differential Revision: https://reviews.freebsd.org/D36443 > --- > sys/dev/bnxt/bnxt.h | 3 +- > sys/dev/bnxt/bnxt_hwrm.c | 110 > ++++++++++++++++++++++++++++------------------- > sys/dev/bnxt/bnxt_hwrm.h | 7 ++- > sys/dev/bnxt/if_bnxt.c | 7 ++- > 4 files changed, 74 insertions(+), 53 deletions(-) > > This commit appears to have broken vlan on these interfaces. > My hardware is a Broadcom BCM57416 NetXtreme-E 10GBase-T Ethernet, (in a > Dell T640, if that helps). > > A simple vlan creation on top of one: > ifconfig vlan create > ifconfig vlan0 vlan 201 vlandev bnxt0 > > Results in a loss of connectivity. The kernel logs this, which I assume i= s > related: > > `bnxt0: HWRM_CFA_L2_FILTER_ALLOC command returned INVALID_PARAMS error.` > > After reverting this (and 72e9dbb58cad5262190cf2eae47f764021072128) I can > create vlan interfaces on top of bnxt0 without losing connectivity. > > Should we revert this before 14.0? > > There=E2=80=99s also a report of what I think is the same issue in > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D269133 > > There=E2=80=99s a proposed patch there, but it did not work for me. > I think we're going to need to, unless Sumit and/or the broadcom team has a solution. This bug is biting more people than the bugs it supposedly fixed. Warner --000000000000b52593060389a0ab Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Tue, Aug 22, 2023 at 3:07=E2=80=AF= PM Kristof Provost <kp@freebsd.org= > wrote:
<= /u>

On 27 Jun 2023, at 11:17, Kristof Provost wrote:

On 4 Nov 2022, at 23:55, Warner Losh wrote:

The branch main = has been updated by imp:

URL: https://cgit.Fre= eBSD.org/src/commit/?id=3D91fcacc355971f74aa26fc7861020dc3a2a2d717

commit 91fcacc355971f74aa26fc7861020dc3a2a2d717
Author: Sumit Saxena <sumit.saxena@broadcom.com>
AuthorDate: 2022-11-04 22:24:32 +0000
Commit: Warner Losh <imp@FreeBSD.org>
CommitDate: 2022-11-04 22:24:32 +0000

if_bnxt: Add support for VLAN on Thor

Reviewed by: imp
Differential Revision: https://reviews.freebsd.org/D36443
---
sys/dev/bnxt/bnxt.h | 3 +-
sys/dev/bnxt/bnxt_hwrm.c | 110 ++++++++++++++++++++++++++++---------------= ----
sys/dev/bnxt/bnxt_hwrm.h | 7 ++-
sys/dev/bnxt/if_bnxt.c | 7 ++-
4 files changed, 74 insertions(+), 53 deletions(-)

This commit appears to have broken vlan on the= se interfaces.
My hardware is a Broadcom BCM57416 NetXtreme-E 10GBase-T Ethernet, (in a De= ll T640, if that helps).

A simple vlan creation on top of one:
ifconfig vlan create
ifconfig vlan0 vlan 201 vlandev bnxt0

Results in a loss of connectivity. The kernel logs this, wh= ich I assume is related:

`bnxt0: HWRM_CFA_L2_FILTER_ALLOC command returned INVALID_P= ARAMS error.`

After reverting this (and 72e9dbb58cad5262190cf2eae47f76402= 1072128) I can create vlan interfaces on top of bnxt0 without losing connec= tivity.


Should we revert this before 14.0?

There=E2=80=99s also a report of what I think is the same i= ssue in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D2= 69133

There=E2=80=99s a proposed patch there, but it did not work= for me.


I think we&#= 39;re going to need to, unless Sumit and/or the broadcom team has a solutio= n. This bug is biting more people than the bugs it supposedly fixed.
<= div>
Warner=C2=A0
--000000000000b52593060389a0ab--