From owner-freebsd-ports@FreeBSD.ORG Sun Jun 24 22:13:58 2012 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BC9DC106566B for ; Sun, 24 Jun 2012 22:13:58 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-ob0-f182.google.com (mail-ob0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id 76A818FC16 for ; Sun, 24 Jun 2012 22:13:58 +0000 (UTC) Received: by obbun3 with SMTP id un3so7002229obb.13 for ; Sun, 24 Jun 2012 15:13:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=3WWe2dljTjf6thYXiTXdikHLaYUTd29RUlrI47wVbHg=; b=t1ig7nikF4jOSikSWjmPcU/GTO4Zagd1mtBslW6VSIy0TCLKHKk8ZactvvM9h9YCbA Iir7+QL//AoqWSOC46gaFBM3WxkyGTkYGuYBegzV6T5Jzjlj7EZlYd1Z7X/zn3c+LGqV 0qdyRdpM9cNyKG/pjBMdbgdb9AT8vhsLeOT2k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:x-gm-message-state; bh=3WWe2dljTjf6thYXiTXdikHLaYUTd29RUlrI47wVbHg=; b=H2CS3X898px4t93ypAQDfsosuJMFDboqbIOgQbkGN98WFX8JgrRwEu/CFPtHzAY/So RwTqMlJZ2qS3s/0AF64Gth9E3i2csjQooSg7VfwOjbP4u6BlWnNb/gbmBI1VsqTbtGCU LAh11UdVyhigwfLGV5rOtzs1dBhp5avpk/IxmrPyECQ3c7rwz23PAeI1HgxtI29yME+7 FJbwAyPL08FiDtgx++kkABQ4lzjNYE9bI+odYuhTqxSt4Lqa0cHZM/rrjz3g45zdZbeR igQYHloMdX2NjPXZQDEaFAhD0ehQ65uUJumyk1uGjga0sPNUx/ImH+C+RVQRrCrw4Ehq GuBA== Received: by 10.182.131.2 with SMTP id oi2mr9962071obb.43.1340576037889; Sun, 24 Jun 2012 15:13:57 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.125.70 with HTTP; Sun, 24 Jun 2012 15:13:26 -0700 (PDT) In-Reply-To: <4FE78DF5.1090709@FreeBSD.org> References: <4FE6F010.80609@FreeBSD.org> <4FE78DF5.1090709@FreeBSD.org> From: Eitan Adler Date: Sun, 24 Jun 2012 15:13:26 -0700 Message-ID: To: Doug Barton Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQkgdbsmeSxtMOs3PekbkXUipDz5+utD/ca8iHPn5DLUGUA+RNMPBmolMIz+WYjav2HKlv/j Cc: Alex Kozlov , FreeBSD ports list Subject: Re: X11BASE still in use in ports X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Jun 2012 22:13:58 -0000 On 24 June 2012 15:00, Doug Barton wrote: > On 06/24/2012 11:05, Eitan Adler wrote: >> On 24 June 2012 03:46, Doug Barton wrote: >>> I noticed a failure in one of my ports today while doing an upgrade, and >>> was embarrassed to find that it was due to my port still using X11BASE. >>> That led me to do a quick grep of the tree, which seems to indicate that >>> there are a non-zero number of uses of it which seem to be erroneous: >> >> When the patch was committed a exp-run was done. > > Which isn't even close to being a thorough treatment. The *only* way to > do this kind of work is with grep through the entire tree. That should > have been done before the variable was removed. It wasn't the only thing that was done. > FWIW, there seem to be 3 categories of problems in ak's list. First, the > variable isn't reached without an option being enabled (this is why > exp-runs are not sufficient) I thought we fixed all of these already. > Second, the X11BASE was redundant, ala: > -I${LOCALBASE}/include -I${X11BASE}/include I fixed the ones I saw of these, but I wasn't too concerned about getting them all. > Third, it was just plain broken. hm? -- Eitan Adler