Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 14 Aug 2011 12:26:25 +0000 (UTC)
From:      Adrian Chadd <adrian@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-user@freebsd.org
Subject:   svn commit: r224863 - user/adrian/if_ath_tx/sys/dev/ath
Message-ID:  <201108141226.p7ECQPMj064076@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: adrian
Date: Sun Aug 14 12:26:24 2011
New Revision: 224863
URL: http://svn.freebsd.org/changeset/base/224863

Log:
  Write out some notes about BAR response processing and what we're (currently)
  missing.

Modified:
  user/adrian/if_ath_tx/sys/dev/ath/if_ath_tx.c

Modified: user/adrian/if_ath_tx/sys/dev/ath/if_ath_tx.c
==============================================================================
--- user/adrian/if_ath_tx/sys/dev/ath/if_ath_tx.c	Sun Aug 14 12:21:08 2011	(r224862)
+++ user/adrian/if_ath_tx/sys/dev/ath/if_ath_tx.c	Sun Aug 14 12:26:24 2011	(r224863)
@@ -2494,6 +2494,13 @@ ath_addba_stop(struct ieee80211_node *ni
 	ATH_TXQ_UNLOCK(txq);
 }
 
+/*
+ * Note: net80211 bar_timeout() doesn't call this function on BAR failure;
+ * it simply tears down the aggregation session. Ew.
+ *
+ * It however will call ieee80211_ampdu_stop() which will call
+ * ic->ic_addba_stop().
+ */
 void
 ath_bar_response(struct ieee80211_node *ni, struct ieee80211_tx_ampdu *tap,
     int status)
@@ -2503,4 +2510,7 @@ ath_bar_response(struct ieee80211_node *
 	device_printf(sc->sc_dev, "%s: called\n", __func__);
 
 	sc->sc_bar_response(ni, tap, status);
+	/* Note: This may update the BAW details */
+
+	/* Unpause the TID */
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201108141226.p7ECQPMj064076>