From owner-freebsd-bugs@FreeBSD.ORG  Wed Dec  7 07:10:11 2011
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 05590106564A
	for <freebsd-bugs@hub.freebsd.org>;
	Wed,  7 Dec 2011 07:10:11 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id AF36A8FC0C
	for <freebsd-bugs@hub.freebsd.org>;
	Wed,  7 Dec 2011 07:10:10 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id pB77AA3n028195
	for <freebsd-bugs@freefall.freebsd.org>; Wed, 7 Dec 2011 07:10:10 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id pB77AAhs028194;
	Wed, 7 Dec 2011 07:10:10 GMT (envelope-from gnats)
Date: Wed, 7 Dec 2011 07:10:10 GMT
Message-Id: <201112070710.pB77AAhs028194@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: kern/162741: commit references a PR
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Dec 2011 07:10:11 -0000

The following reply was made to PR kern/162741; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/162741: commit references a PR
Date: Wed,  7 Dec 2011 07:03:23 +0000 (UTC)

 Author: alc
 Date: Wed Dec  7 07:03:14 2011
 New Revision: 228317
 URL: http://svn.freebsd.org/changeset/base/228317
 
 Log:
   Eliminate the possibility of 32-bit arithmetic overflow in the calculation
   of vm_kmem_size that may occur if the system administrator has specified a
   vm.vm_kmem_size tunable value that exceeds the hard cap.
   
   PR:		162741
   Submitted by:	Adam McDougall
   Reviewed by:	bde@
   MFC after:	3 weeks
 
 Modified:
   head/sys/kern/kern_malloc.c
 
 Modified: head/sys/kern/kern_malloc.c
 ==============================================================================
 --- head/sys/kern/kern_malloc.c	Wed Dec  7 00:22:34 2011	(r228316)
 +++ head/sys/kern/kern_malloc.c	Wed Dec  7 07:03:14 2011	(r228317)
 @@ -740,11 +740,11 @@ kmeminit(void *dummy)
  	/*
  	 * Limit kmem virtual size to twice the physical memory.
  	 * This allows for kmem map sparseness, but limits the size
 -	 * to something sane. Be careful to not overflow the 32bit
 -	 * ints while doing the check.
 +	 * to something sane.  Be careful to not overflow the 32bit
 +	 * ints while doing the check or the adjustment.
  	 */
 -	if (((vm_kmem_size / 2) / PAGE_SIZE) > cnt.v_page_count)
 -		vm_kmem_size = 2 * cnt.v_page_count * PAGE_SIZE;
 +	if (vm_kmem_size / 2 / PAGE_SIZE > mem_size)
 +		vm_kmem_size = 2 * mem_size * PAGE_SIZE;
  
  #ifdef DEBUG_MEMGUARD
  	tmp = memguard_fudge(vm_kmem_size, vm_kmem_size_max);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"