Date: Sun, 04 Feb 2018 22:23:10 +0000 From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: maintainer-feedback requested: [Bug 225672] graphics/poppler-glib: Build fails with OPENJPEG disabled Message-ID: <bug-225672-6497-IXYmu175Mu@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-225672-6497@https.bugs.freebsd.org/bugzilla/> References: <bug-225672-6497@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
Vladimir Krstulja <vlad-fbsd@acheronmedia.com> has reassigned Bugzilla Automation <bugzilla@FreeBSD.org>'s request for maintainer-feedback to gnome@FreeBSD.org: Bug 225672: graphics/poppler-glib: Build fails with OPENJPEG disabled https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D225672 --- Description --- Created attachment 190326 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D190326&action= =3Dedit Correct OPENJPEG option's function both for MASTER and SLAVES With OPENJPEG option disabled, build of poppler-glib fails. The problem seems to be in the graphics/poppler (master) conditional that checks whether it's a SLAVE or MASTER build. The conditional is setting OPTIONS-defined CONFIGURE_ARGS only for MASTER (though the comment for the .else section seems to think it's for SLAVES), so for slaves the missing OPENJPEG option does not set --enable-libopenjpeg to none. As the default for that is "auto", the build fails at configure stage, look= ing for libopenjpeg: > configure: error: Install libopenjpeg2 or libopenjpeg1 before trying to b= uild poppler. You can also decide to use the internal unmaintained JPX decoder or none at all. See --help. This patch extracts the OPENJPEG conditional outside of master-slave check (thus it applies for both), and now poppler, poppler-utils, poppler-data and poppler-glib build fine, with OPENJPEG disabled. Please note I don't know if this breaks anything functionally, or even if i= t's the correct thing to do, or it is but CAIRO and CURL options need to be extracted outside of the master-slave conditional as well. Build tested with Poudriere 11.1 amd64.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-225672-6497-IXYmu175Mu>