From owner-freebsd-gnome@freebsd.org Sun Feb 4 22:23:12 2018 Return-Path: Delivered-To: freebsd-gnome@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3C452ED663E for ; Sun, 4 Feb 2018 22:23:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id C9C2F750EA for ; Sun, 4 Feb 2018 22:23:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 87AF7ED6636; Sun, 4 Feb 2018 22:23:11 +0000 (UTC) Delivered-To: gnome@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7504AED6635 for ; Sun, 4 Feb 2018 22:23:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 08E1E750E5 for ; Sun, 4 Feb 2018 22:23:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 51DDB2146E for ; Sun, 4 Feb 2018 22:23:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w14MNAgW057996 for ; Sun, 4 Feb 2018 22:23:10 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w14MNAMj057995 for gnome@FreeBSD.org; Sun, 4 Feb 2018 22:23:10 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: maintainer-feedback requested: [Bug 225672] graphics/poppler-glib: Build fails with OPENJPEG disabled Date: Sun, 04 Feb 2018 22:23:10 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: gnome@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Feb 2018 22:23:12 -0000 Vladimir Krstulja has reassigned Bugzilla Automation 's request for maintainer-feedback to gnome@FreeBSD.org: Bug 225672: graphics/poppler-glib: Build fails with OPENJPEG disabled https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D225672 --- Description --- Created attachment 190326 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D190326&action= =3Dedit Correct OPENJPEG option's function both for MASTER and SLAVES With OPENJPEG option disabled, build of poppler-glib fails. The problem seems to be in the graphics/poppler (master) conditional that checks whether it's a SLAVE or MASTER build. The conditional is setting OPTIONS-defined CONFIGURE_ARGS only for MASTER (though the comment for the .else section seems to think it's for SLAVES), so for slaves the missing OPENJPEG option does not set --enable-libopenjpeg to none. As the default for that is "auto", the build fails at configure stage, look= ing for libopenjpeg: > configure: error: Install libopenjpeg2 or libopenjpeg1 before trying to b= uild poppler. You can also decide to use the internal unmaintained JPX decoder or none at all. See --help. This patch extracts the OPENJPEG conditional outside of master-slave check (thus it applies for both), and now poppler, poppler-utils, poppler-data and poppler-glib build fine, with OPENJPEG disabled. Please note I don't know if this breaks anything functionally, or even if i= t's the correct thing to do, or it is but CAIRO and CURL options need to be extracted outside of the master-slave conditional as well. Build tested with Poudriere 11.1 amd64.