From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Jun 27 09:40:09 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 01144106564A for ; Wed, 27 Jun 2012 09:40:09 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D2BEC8FC20 for ; Wed, 27 Jun 2012 09:40:08 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q5R9e88i007985 for ; Wed, 27 Jun 2012 09:40:08 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q5R9e8pg007984; Wed, 27 Jun 2012 09:40:08 GMT (envelope-from gnats) Resent-Date: Wed, 27 Jun 2012 09:40:08 GMT Resent-Message-Id: <201206270940.q5R9e8pg007984@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Romain Tartiere Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D2080106564A; Wed, 27 Jun 2012 09:38:29 +0000 (UTC) (envelope-from romain@blogreen.org) Received: from marvin.blogreen.org (unknown [IPv6:2001:470:1f12:b9c::2]) by mx1.freebsd.org (Postfix) with ESMTP id 433D18FC14; Wed, 27 Jun 2012 09:38:29 +0000 (UTC) Received: by marvin.blogreen.org (Postfix, from userid 1001) id 3B2BD41998; Wed, 27 Jun 2012 11:38:28 +0200 (CEST) Message-Id: <20120627093828.3B2BD41998@marvin.blogreen.org> Date: Wed, 27 Jun 2012 11:38:28 +0200 (CEST) From: Romain Tartiere To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: swills@FreeBSD.org Subject: ports/169481: [patch] sysutils/puppet fails to install packages X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Romain Tartiere List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2012 09:40:09 -0000 >Number: 169481 >Category: ports >Synopsis: [patch] sysutils/puppet fails to install packages >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Jun 27 09:40:08 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Romain Tartiere >Release: FreeBSD 9.0-STABLE amd64 >Organization: >Environment: System: FreeBSD marvin.blogreen.org 9.0-STABLE FreeBSD 9.0-STABLE #31 r237367: Thu Jun 21 11:52:53 CEST 2012 root@marvin.blogreen.org:/usr/obj/usr/src/sys/MARVIN amd64 >Description: When using puppet with the default options, trying to install a package with a manifest including for example the following lines will fail: ------ [beginning of manifest] ------ [...] package { "sysutils/tmux": ensure => installed, } [...] --------- [end of manifest] --------- ------ [beginning of failure details] ------ # puppet agent --test --debug [...] debug: Prefetching freebsd resources for package debug: Puppet::Type::Package::ProviderFreebsd: Executing '/usr/sbin/pkg_info -aoQ' debug: Puppet::Type::Package::ProviderFreebsd: Executing '/usr/sbin/pkg_info -aoQ' debug: Package: sysutils/tmux: origin => {:port_category=>"sysutils", :port_name=>"tmux"} debug: Package: sysutils/tmux: source => # debug: Fetching INDEX: # err: /Stage[main]/XXXX/Package[sysutils/tmux]/ensure: change from absent to present failed: Could not set 'present on ensure: can't convert nil into String at /usr/local/etc/puppet/manifests/site.pp:27 --------- [end of failure details] --------- The file /usr/local/lib/ruby/site_ruby/1.8/puppet/provider/package/freebsd.rb is patched from the origninal one by the port, but the error is tied into it. Relevant code: ------ [beginning of failing code] ------ 77 Puppet.debug "Fetching INDEX: #{uri.inspect}" 78 begin 79 open(uri, "r") do |f| 80 Bzip2::Reader.open(f.path) do |f| 81 while (line = f.gets) 82 fields = line.split("|") 83 pkg_info = self.class.parse_pkg_string(fields[0]) 84 origin = self.class.parse_origin(fields[1]) 85 @@ports_index[origin] = pkg_info 86 end 87 end 88 end 89 rescue IOError, OpenURI::HTTPError, Net::FTPError 90 @@ports_index = nil 91 raise Puppet::Error.new "Could not fetch ports INDEX: #{$!}" 92 end --------- [end of failing code] --------- >From IRB, the object provided by open at line 79 has no #path:: ------ [beginning of failing code] ------ irb(main):001:0> require 'open-uri' => true irb(main):002:0> open("http://packages.blogreen.org/INDEX-9.bz2", "r") do |f| irb(main):003:1* f.path irb(main):004:1> end => nil --------- [end of failing code] --------- Maybe this is a regression or something... AFAICR, this code used to work a while ago. >How-To-Repeat: Try to install a package. >Fix: Bzip2::Reader.open seems to accept URIs, so we can just apply this change: ------ [beginning of fix] ------ --- files/optpatch-package_origin.orig 2012-06-27 11:34:23.466621862 +0200 +++ files/optpatch-package_origin 2012-06-27 11:34:53.903314301 +0200 @@ -96,14 +96,12 @@ + uri = source.merge "INDEX.bz2" + Puppet.debug "Fetching INDEX: #{uri.inspect}" + begin -+ open(uri, "r") do |f| -+ Bzip2::Reader.open(f.path) do |f| -+ while (line = f.gets) -+ fields = line.split("|") -+ pkg_info = self.class.parse_pkg_string(fields[0]) -+ origin = self.class.parse_origin(fields[1]) -+ @@ports_index[origin] = pkg_info -+ end ++ Bzip2::Reader.open(uri) do |f| ++ while (line = f.gets) ++ fields = line.split("|") ++ pkg_info = self.class.parse_pkg_string(fields[0]) ++ origin = self.class.parse_origin(fields[1]) ++ @@ports_index[origin] = pkg_info + end + end + rescue IOError, OpenURI::HTTPError, Net::FTPError --------- [end of fix] --------- >Release-Note: >Audit-Trail: >Unformatted: