From owner-svn-src-head@FreeBSD.ORG  Thu Oct  2 10:32:25 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id C9FD0842;
 Thu,  2 Oct 2014 10:32:25 +0000 (UTC)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4D60FBD4;
 Thu,  2 Oct 2014 10:32:24 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id s92AWMtX089656
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Thu, 2 Oct 2014 14:32:22 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id s92AWM0L089655;
 Thu, 2 Oct 2014 14:32:22 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Thu, 2 Oct 2014 14:32:22 +0400
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: "Alexander V. Chernikov" <melifaro@FreeBSD.org>
Subject: Re: svn commit: r272391 - in head/sys: netinet netinet6
Message-ID: <20141002103222.GG73266@FreeBSD.org>
References: <201410020025.s920PvEW008958@svn.freebsd.org>
 <542D09CF.5000803@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <542D09CF.5000803@FreeBSD.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 Hiroki Sato <hrs@FreeBSD.org>, src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Oct 2014 10:32:25 -0000

On Thu, Oct 02, 2014 at 12:16:15PM +0400, Alexander V. Chernikov wrote:
A> On 02.10.2014 04:25, Hiroki Sato wrote:
A> > Author: hrs
A> > Date: Thu Oct  2 00:25:57 2014
A> > New Revision: 272391
A> > URL: https://svnweb.freebsd.org/changeset/base/272391
A> >
A> > Log:
A> >    Add an additional routing table lookup when m->m_pkthdr.fibnum is changed
A> >    at a PFIL hook in ip{,6}_output().  IPFW setfib rule did not perform
A> >    a routing table lookup when the destination address was not changed.
A> >    
A> >    CR:	D805
A> >
A> > Modified:
A> >    head/sys/netinet/ip_output.c
A> >    head/sys/netinet6/ip6_output.c
A> I'm not very happy with this.
A> We already have large conditional for checking if dst has changed, how 
A> you have added another conditional for fib..
A> This idea is quite weird: why should we try to check all this stuff for 
A> every packet instead of asking pfil consumers
A> to provide information they already know?
A> 
A> We'd better discuss something like M_DSTCHANGED flag instead of doing 
A> these hacks.

And here you suggest to abuse mbuf flags to merely carry return value of
a pfil hook :)

-- 
Totus tuus, Glebius.