Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 16 Sep 2018 13:38:31 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 231189] security/py-gssapi: Strip libraries; add ssl
Message-ID:  <bug-231189-7788-XMiuypfHzP@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-231189-7788@https.bugs.freebsd.org/bugzilla/>
References:  <bug-231189-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D231189

--- Comment #2 from John W. O'Brien <john@saltant.com> ---
Created attachment 197144
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D197144&action=
=3Dedit
security/py-gssapi: Strip shared objects, use ssl when needed

Nathan, I've revised your patch as follows.

*   Before patching, poudriere testport only emits the USES=3Dssl warning if
GSSAPI_BASE is selected. With your patch, it no longer warns on GSSAPI_BASE,
but does emit "Warning: you may not need USES=3Dssl" on both other GSSAPI
options. Therefore I moved "ssl" from the general USES to GSSAPI_BASE_USES.
Could you please confirm that this also works for you?

*   I would prefer to avoid the sub-shell + cd pattern in this case. There =
is
no benefit to setting the CWD on behalf of the subsequent work---as there w=
ould
be for running a test suite, for instance---so stripping in three steps ins=
tead
of one just adds complexity, and is more likely to increase the scope of fu=
ture
diffs. While here, I parameterize the package directory.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-231189-7788-XMiuypfHzP>