From owner-svn-src-head@freebsd.org  Tue Jul 31 22:18:42 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 697ED1066AFF;
 Tue, 31 Jul 2018 22:18:42 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 24A70809AB;
 Tue, 31 Jul 2018 22:18:42 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 1D05C1C525; Tue, 31 Jul 2018 22:18:42 +0000 (UTC)
Date: Tue, 31 Jul 2018 22:18:42 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Emmanuel Vadot <manu@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r337004 - head/sys/dev/ofw
Message-ID: <20180731221842.GA79074@FreeBSD.org>
References: <201807312050.w6VKoopE027843@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201807312050.w6VKoopE027843@repo.freebsd.org>
User-Agent: Mutt/1.9.5 (2018-04-13)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Jul 2018 22:18:42 -0000

On Tue, Jul 31, 2018 at 08:50:50PM +0000, Emmanuel Vadot wrote:
> New Revision: 337004
> URL: https://svnweb.freebsd.org/changeset/base/337004
> 
> Log:
>   ofw_cpu: Add support for getting cpu clock via clock property
>   
>   Nominal Mhz is either expressed via the clock-frequency property
> ...
> +#ifdef EXT_RESOURCES
> +		rv = clk_get_by_ofw_index(dev, 0, 0, &cpuclk);
> +		if (rv == 0) {
> +			rv = clk_get_freq(cpuclk, &freq);
> +			if (rv != 0 && bootverbose)
> +				device_printf(dev,
> +				    "Cannot get freq of property clocks\n");

Why informal "freq" contraction, esp. when it's properly spelled out few
lines below?

> +			if (bootverbose)
> +				device_printf(dev,
> +				    "missing 'clock-frequency' property\n");
>  	} else
>  		sc->sc_nominal_mhz = cell / 1000000; /* convert to MHz */
>  
> +	if (sc->sc_nominal_mhz != 0 && bootverbose)
> +		device_printf(dev, "Nominal frequency %dMhz\n",

I think correct spelling is MHz, not Mhz.  Notice that comment above uses
this spelling.

./danfe