From owner-freebsd-current@FreeBSD.ORG  Wed Jun 16 20:09:37 2010
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C792C106566B;
	Wed, 16 Jun 2010 20:09:37 +0000 (UTC) (envelope-from jilles@stack.nl)
Received: from mx1.stack.nl (relay04.stack.nl [IPv6:2001:610:1108:5010::107])
	by mx1.freebsd.org (Postfix) with ESMTP id 8A4F48FC1C;
	Wed, 16 Jun 2010 20:09:37 +0000 (UTC)
Received: from turtle.stack.nl (turtle.stack.nl [IPv6:2001:610:1108:5010::132])
	by mx1.stack.nl (Postfix) with ESMTP id 255901DD68B;
	Wed, 16 Jun 2010 22:09:36 +0200 (CEST)
Received: by turtle.stack.nl (Postfix, from userid 1677)
	id 10D9F1729C; Wed, 16 Jun 2010 22:09:36 +0200 (CEST)
Date: Wed, 16 Jun 2010 22:09:36 +0200
From: Jilles Tjoelker <jilles@stack.nl>
To: Jaakko Heinonen <jh@FreeBSD.org>
Message-ID: <20100616200935.GA26321@stack.nl>
References: <4C16C5B5.1070308@FreeBSD.org>
	<20100616190416.GA3896@a91-153-117-195.elisa-laajakaista.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100616190416.GA3896@a91-153-117-195.elisa-laajakaista.fi>
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: FreeBSD Current <freebsd-current@freebsd.org>,
	Gabor Kovesdan <gabor@FreeBSD.org>, i18n@FreeBSD.org
Subject: Re: [CFT] BSDL iconv in base system
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Jun 2010 20:09:37 -0000

On Wed, Jun 16, 2010 at 10:04:16PM +0300, Jaakko Heinonen wrote:
> On 2010-06-15, Gabor Kovesdan wrote:
> > - The iconv.h header files is supposed to be compatible with the GNU 
> > version, i.e. sources should build with base iconv.h and GNU libiconv. 
> > I've just did a very quick test and it seems ports can safely link to 
> > GNU libiconv, there's no conflict.

> > The rather big patch (42,5M) is available here: 
> > http://www.kovesdan.org/patches/iconv_base_integrate.diff

> iconv(3) prototype doesn't conform to POSIX.1-2008. Is it a
> well-considered decision?

I think the difference from POSIX.1-2008 is pretty common and may
therefore cause less compilation problems. NetBSD's Citrus iconv and GNU
iconv have the extra 'const', and so does the default Solaris iconv
(Solaris has a separate iconv for standards-conforming applications with
the POSIX prototype.)

-- 
Jilles Tjoelker