From owner-svn-src-all@freebsd.org Tue Dec 4 18:55:37 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B9BD713178EA for ; Tue, 4 Dec 2018 18:55:36 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BBDD66C7DB for ; Tue, 4 Dec 2018 18:55:35 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x82a.google.com with SMTP id l11so19363142qtp.0 for ; Tue, 04 Dec 2018 10:55:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=U8YvndzuXh6k400Ms+mu8FpyyqUhYo9yQEexUde/Fdw=; b=f7tapGdnjf4vbzvceDevl997qQa9MzzOt4ifWRBNDBxVudKzGGyq19noyIcrPBJU/w aQOHiqDlSAyDxbGfH2dQjlbQy2+1nJHn6vT6qkVFPkMiOA+p5waFwGwBnmpghksWBVVY CAiVD9nNkoIJEa047kKFe5PWPb5Y7+i4vhmw0zOMe8KUA+UIEhWVtTyasmQNji9D46/b Rv/ZtIaCmOxbZ6jyHlXbHlcg6BvfCbxxDFTli8Ghe1sHXwi36yhFTkW96NK6okbsdBgf 1vMq2rA74qDU7oKKJr+nNZgbUp9NgyQsayYy3lT/FWBojyTklMKkKaKAyC6prnRQSb94 PtDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=U8YvndzuXh6k400Ms+mu8FpyyqUhYo9yQEexUde/Fdw=; b=D1t4F6uSZTDDUwNVY1E6XCUlLSGdroFr/DWuVbsqsIlXw06cm8jSeKcLIinxbxKdtm hddwGg66tCwGpjX7bQXvZGX0vtZ+hyXwdul0LAAFs/E3LkmGRLc0GSSRc80L9LOySRnN lZyLhySTgx44Wxd/S6bZHAoKT1xvi3YiYP/LaL7G9AvuDrEFiTow57/7GIn4OIEl28Z/ YzBv12HmRjts0nl/MrD253+m4dBYnC66+4foKoAq/HuZ2vzFWDa1posKr4NzLyx9TGRC L2JZqdHZVQRxY5W3QmaiqGSBk5nJS7kE1GT+d54/0P/8L+CnZlrwdvSZpakO0iLzM/cB 2kOg== X-Gm-Message-State: AA+aEWaAed2272a5ZySc+XAMfppct2M4Ybsy51N500l20++RhpZRT5gS +NvhxHSbut4+RCaXE9RM1+VliSr7W4czAJzNsnO78A== X-Google-Smtp-Source: AFSGD/UE3TT28EW7TGpKOBNR4/w8s9iOCBnW/4Q0TXxPPO5R6fgQH6tBcOerd9V/ONsBMhbC6S7bVKxJ9p90Y5mgkus= X-Received: by 2002:ac8:3f2d:: with SMTP id c42mr20655400qtk.33.1543949735063; Tue, 04 Dec 2018 10:55:35 -0800 (PST) MIME-Version: 1.0 References: <201812041813.wB4IDhd1037433@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201812041813.wB4IDhd1037433@pdx.rh.CN85.dnsmgr.net> From: Warner Losh Date: Tue, 4 Dec 2018 11:55:23 -0700 Message-ID: Subject: Re: svn commit: r341464 - head/sbin/savecore To: "Rodney W. Grimes" Cc: Xin LI , Renato Botelho do Couto , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: BBDD66C7DB X-Spamd-Result: default: False [-4.55 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_FIVE(0.00)[6]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; MX_GOOD(-0.01)[cached: ALT1.aspmx.l.google.com]; RCVD_IN_DNSWL_NONE(0.00)[a.2.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.97)[-0.975,0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_LAST(0.00)[]; IP_SCORE(-1.57)[ip: (-4.92), ipnet: 2607:f8b0::/32(-1.54), asn: 15169(-1.28), country: US(-0.09)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; FREEMAIL_CC(0.00)[gmail.com] X-Rspamd-Server: mx1.freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Dec 2018 18:55:37 -0000 On Tue, Dec 4, 2018 at 11:14 AM Rodney W. Grimes < freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > On Tue, Dec 4, 2018 at 9:28 AM Rodney W. Grimes > > > > > > > Author: garga (ports committer) > > > > Date: Tue Dec 4 12:34:22 2018 > > > > New Revision: 341464 > > > > URL: https://svnweb.freebsd.org/changeset/base/341464 > > > > > > > > Log: > > > > Restore /var/crash permissions to 0750, as declared in mtree file. > After > > > > r337337 it changed to 0755. > > > > > > > > Reviewed by: loos > > > > Approved by: loos > > > > MFC after: 3 days > > > > Sponsored by: Rubicon Communications, LLC (Netgate) > > > > Differential Revision: https://reviews.freebsd.org/D18355 > > > > > > This probably warrants an EN against 12.0 release. > > > > Can we just fix it before 12.0-RELEASE builds starts? It would be > > much more robust compared to delivering a "fixit" script though > > freebsd-update... > > Thats Glens call, but normal procedure is 0 change between > last RC and release. > Let's not be too pedantic here: This is a security issue and let's not let our process get in the way of fixing a simple security issue. Warner > (Bcc:'ed to gjb@, and trimmed a bit) > > Rod > > > > +++ head/sbin/savecore/Makefile Tue Dec 4 12:34:22 2018 > (r341464) > > > > @@ -2,7 +2,9 @@ > > > > > > > > PACKAGE=runtime > > > > CONFS= minfree > > > > -CONFSDIR= /var/crash > > > > +VAR_CRASH= /var/crash > > > > +VAR_CRASH_MODE= 0750 > > > > +CONFSDIR= VAR_CRASH > > > > PROG= savecore > > > > LIBADD= z xo > > > > MAN= savecore.8 > -- > Rod Grimes > rgrimes@freebsd.org > >