Date: Tue, 29 Aug 2006 11:20:09 +0200 From: "Simon L. Nielsen" <simon@FreeBSD.org> To: Jeremie Le Hen <jeremie@le-hen.org> Cc: Julian Elischer <julian@elischer.org>, FreeBSD Net <net@freebsd.org> Subject: Re: [fbsd] Re: possible patch for implementing split DNS Message-ID: <20060829092009.GC982@zaphod.nitro.dk> In-Reply-To: <20060829090148.GD15761@obiwan.tataz.chchile.org> References: <44EF6E18.6090905@elischer.org> <44EF74CD.6080500@elischer.org> <20060829085001.GB982@zaphod.nitro.dk> <20060829090148.GD15761@obiwan.tataz.chchile.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2006.08.29 11:01:48 +0200, Jeremie Le Hen wrote:
Hey,
> On Tue, Aug 29, 2006 at 10:50:02AM +0200, Simon L. Nielsen wrote:
> > On 2006.08.25 15:08:13 -0700, Julian Elischer wrote:
> > Since a bunch of people have suggested other solutions I just wanted
> > to add me 0.01$CURRENCY, FWIW.
> >
> > Other than missing update for some manual page (not sure where this
> > should go) I don't see a problem adding this patch. "Normal" users
> > should be able already get similar functionality already by simply
> > preloading a custom patched libc, so I don't see a problem supporting
> > this.
>
> I agree with this statement. If users really want to, they can
> compile their own libc. However, nectar@ has added the following
> comment in nsdispatch.c:
>
> % #if defined(_NSS_DEBUG) && defined(_NSS_SHOOT_FOOT)
> % /* NOTE WELL: THIS IS A SECURITY HOLE. This must only be built
> % * for debugging purposes and MUST NEVER be used in production.
> % */
> % path = getenv("NSSWITCH_CONF");
> % if (path == NULL)
> % #endif
> % path = _PATH_NS_CONF;
>
> We should remove this #if clause because of your argument. I'm not sure
> it is worth documenting it however.
Well, nsswitch is part of the user authentication framework (I think),
so I'm not entirely sure if exactly the same argument can be used
safely. I never really had a need to look at nsswitch, so I don't
know if it's used in contexts (other than set[ug]id) where overriding
nsswitch.conf can cause problems.
At least if that #if is removed it's probably required to add a
issetugid() check.
--
Simon L. Nielsen
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060829092009.GC982>
