From owner-freebsd-doc Tue Sep 19 10: 1:12 2000 Delivered-To: freebsd-doc@freebsd.org Received: from scientia.demon.co.uk (scientia.demon.co.uk [212.228.14.13]) by hub.freebsd.org (Postfix) with ESMTP id 0780037B422; Tue, 19 Sep 2000 10:01:05 -0700 (PDT) Received: from strontium.scientia.demon.co.uk ([192.168.91.36] ident=root) by scientia.demon.co.uk with esmtp (Exim 3.16 #1) id 13bQ9a-000HPk-00; Tue, 19 Sep 2000 17:21:54 +0100 Received: (from ben@localhost) by strontium.scientia.demon.co.uk (8.9.3/8.9.3) id RAA60421; Tue, 19 Sep 2000 17:21:54 +0100 (BST) (envelope-from ben) Date: Tue, 19 Sep 2000 17:21:54 +0100 From: Ben Smithurst To: Maxim Sobolev Cc: doc@FreeBSD.org, ports@FreeBSD.org Subject: Re: Porter's Handbook patch Message-ID: <20000919172154.B30774@strontium.scientia.demon.co.uk> References: <39C77CA9.8AED84CA@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2i In-Reply-To: <39C77CA9.8AED84CA@FreeBSD.org> Sender: owner-freebsd-doc@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org Maxim Sobolev wrote: > Please review attached patch, which intended to replace outdated First, you need two spaces after a fullstop. One space is Wrong[tm]. (Of course, if a sentence ends at the end of a line, the existing newline is just as good.) > + If your port installs a shared library(ies), define a I think "If your port installs one or more shared libraries, ..." would sound better. That "library(ies)" looks ugly to me. > + shared library cache. Also this variable, when defined, will > + facilitate addition a appropriate I don't like that much. I'd prefer this: This variable, when defined, will also facilitate addition of an appropriate [...] > + make variable, which should contain list of directories into which s/contain list/contain a list/ > + through sed just like the rest of pkg/PLIST, "&man.sed.1;" instead of plain "sed", please. Other than that, it looks good to me. -- Ben Smithurst / ben@FreeBSD.org / PGP: 0x99392F7D To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-doc" in the body of the message