From nobody Thu Dec 2 04:12:10 2021 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 3A9E018BA25D; Thu, 2 Dec 2021 04:12:15 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta002.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4J4Mwt72hpz3nxX; Thu, 2 Dec 2021 04:12:14 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from shw-obgw-4001a.ext.cloudfilter.net ([10.228.9.142]) by cmsmtp with ESMTP id sY6QmVckPztEjsdSAmSnOK; Thu, 02 Dec 2021 04:12:14 +0000 Received: from spqr.komquats.com ([70.66.148.124]) by cmsmtp with ESMTPA id sdS8m8oz2lt4QsdS9murVo; Thu, 02 Dec 2021 04:12:14 +0000 X-Authority-Analysis: v=2.4 cv=F+dEy4tN c=1 sm=1 tr=0 ts=61a8479e a=Cwc3rblV8FOMdVN/wOAqyQ==:117 a=Cwc3rblV8FOMdVN/wOAqyQ==:17 a=kj9zAlcOel0A:10 a=IOMw9HtfNCkA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=6Y20OxLKzW50sMlEHNwA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 3F951B45; Wed, 1 Dec 2021 20:12:10 -0800 (PST) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.16.1/8.16.1) with ESMTP id 1B24CA8G016980; Wed, 1 Dec 2021 20:12:10 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <202112020412.1B24CA8G016980@slippy.cwsent.com> X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Alexey Dokuchaev cc: Kubilay Kocak , Cy Schubert , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: b8c4bfe660b3 - main - sysutils/reptyr: Address LLVM 13 build failure In-reply-to: References: <202112020054.1B20sZXk040844@gitrepo.freebsd.org> Comments: In-reply-to Alexey Dokuchaev message dated "Thu, 02 Dec 2021 02:36:44 +0000." List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 01 Dec 2021 20:12:10 -0800 X-CMAE-Envelope: MS4xfFc1Yo6nAamLAZXDcIXrtOOazys1MqcNUZH70e1LQzgLmSBX2AIwN27EELxRGPxK0HwY4p9us+7GupfXqP56/ECv81MbcCqugz/A5jegCGOSA18/AMiE 4AbB4y6X/0/WxTeSgzspB++cD/sKg7LmnCCzOaq/HzdxwzSDngUL/63QW+Q4aLcN2olNDFY7Wcmg+SqkwclJJEICvKXCZv5N8zoPO3rKwmN+dnhppXodJPhW tWlWvk2nhuWh7/r1Hi1N0rPQewkDU0cgpEzuAT0CqyQ8zHFmLAYp6uVvgEAuJFEbdza5wwPdZkcsjna4enz4/IcjVHzI+zzus2HBhA2C7PyettPapIUs8S8F uege6cNMmTcEbfZduIoatZbUGxfjniMVFTI8C6ozn6VtpqVU444= X-Rspamd-Queue-Id: 4J4Mwt72hpz3nxX X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N In message , Alexey Dokuchaev writes: > On Thu, Dec 02, 2021 at 12:05:46PM +1100, Kubilay Kocak wrote: > > On 2/12/2021 11:54 am, Cy Schubert wrote: > > > commit b8c4bfe660b373862165a58514f270a51e77e147 > > > > > > sysutils/reptyr: Address LLVM 13 build failure > > > ... > > > 2 errors generated. > > > > Ports usually shouldn't use -Werror and people are strongly encouraged > > to add -Wno-error > > On the other hand, every project really should enable -Werror so the > compiler catches as much as it can for you. Having it enabled during > development is a must, having it enabled in releases is arguable as > it might bring extra burden to maintainer, but it does help to catch > bugs in the environment original developer has no access to, so no, > we don't strongly encourage -Wno-error when specific warnings can be > scoped as it helps to catch other warnings in the future. Now they > will likely went unnoticed, ergo unreported and unfixed. Then it behooves port maintainers to upstream patches whenever possible. This has been fixed using a proper patch and a pull request has been submitted to our upstream. I should have done this from the get-go. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org The need of the many outweighs the greed of the few.