From owner-freebsd-perl@FreeBSD.ORG Sat Sep 24 12:50:03 2011 Return-Path: Delivered-To: perl@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3C3F31065676 for ; Sat, 24 Sep 2011 12:50:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 27ECD8FC17 for ; Sat, 24 Sep 2011 12:50:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p8OCo3V1049393 for ; Sat, 24 Sep 2011 12:50:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p8OCo3as049392; Sat, 24 Sep 2011 12:50:03 GMT (envelope-from gnats) Date: Sat, 24 Sep 2011 12:50:03 GMT Message-Id: <201109241250.p8OCo3as049392@freefall.freebsd.org> To: perl@FreeBSD.org From: Jeremy Chadwick Cc: Subject: Re: ports/160972: devel/p5-Config-Record -- make Test::Pod and friends optional X-BeenThere: freebsd-perl@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Jeremy Chadwick List-Id: maintainer of a number of perl-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Sep 2011 12:50:03 -0000 The following reply was made to PR ports/160972; it has been noted by GNATS. From: Jeremy Chadwick To: Andrej Zverev Cc: bug-followup@FreeBSD.org Subject: Re: ports/160972: devel/p5-Config-Record -- make Test::Pod and friends optional Date: Sat, 24 Sep 2011 05:30:30 -0700 On Sat, Sep 24, 2011 at 04:21:15PM +0400, Andrej Zverev wrote: > I suspect that better to use TEST_DEPENDS in this case. > You can read about it here: http://wiki.freebsd.org/Perl I wasn't aware of this shim -- thank you for pointing me to it! (For the port maintainer: the above link does go over the details). Agreed, TEST_DEPENDS is a much better choice here. I have updated my patch on my web site, and have also included a copy of the updated patch below. -- | Jeremy Chadwick jdc at parodius.com | | Parodius Networking http://www.parodius.com/ | | UNIX Systems Administrator Mountain View, CA, US | | Making life hard for others since 1977. PGP 4BD6C0CB | --- devel/p5-Config-Record/Makefile.orig 2010-01-28 19:01:28.000000000 -0800 +++ devel/p5-Config-Record/Makefile 2011-09-24 05:25:24.000000000 -0700 @@ -14,8 +14,8 @@ MAINTAINER= cm@therek.net COMMENT= Configuration file access -BUILD_DEPENDS+= ${SITE_PERL}/Test/Pod.pm:${PORTSDIR}/devel/p5-Test-Pod \ - ${SITE_PERL}/Test/Pod/Coverage.pm:${PORTSDIR}/devel/p5-Test-Pod-Coverage +TEST_DEPENDS= p5-Test-Pod>=0:${PORTSDIR}/devel/p5-Test-Pod \ + p5-Test-Pod-Coverage>=0:${PORTSDIR}/devel/p5-Test-Pod-Coverage MAN3= Config::Record.3