From owner-cvs-all@FreeBSD.ORG  Wed Aug 15 22:01:16 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5012B16A420
	for <cvs-all@FreeBSD.org>; Wed, 15 Aug 2007 22:01:16 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from mail2.fluidhosting.com (mx22.fluidhosting.com [204.14.89.5])
	by mx1.freebsd.org (Postfix) with SMTP id D783713C46A
	for <cvs-all@FreeBSD.org>; Wed, 15 Aug 2007 22:01:15 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: (qmail 32145 invoked by uid 399); 15 Aug 2007 22:01:14 -0000
Received: from localhost (HELO slave.dougb.net) (dougb@dougbarton.us@127.0.0.1)
	by localhost with ESMTP; 15 Aug 2007 22:01:14 -0000
X-Originating-IP: 127.0.0.1
Date: Wed, 15 Aug 2007 15:01:13 -0700 (PDT)
From: Doug Barton <dougb@FreeBSD.org>
To: Maxim Sobolev <sobomax@FreeBSD.org>
In-Reply-To: <46C34E6C.4090508@FreeBSD.org>
Message-ID: <alpine.BSF.0.999.0708151459590.98973@qbhto.arg>
References: <200708151835.l7FIZ6pd025066@repoman.freebsd.org>
	<alpine.BSF.0.999.0708151200030.98070@qbhto.arg>
	<46C34E6C.4090508@FreeBSD.org>
X-message-flag: Outlook -- Not just for spreading viruses anymore!
X-OpenPGP-Key-ID: 0xD5B2F0FB
Organization: http://www.FreeBSD.org/
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; format=flowed; charset=us-ascii
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/net/ser Makefile ports/net/ser/files ser.in
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Aug 2007 22:01:16 -0000

On Wed, 15 Aug 2007, Maxim Sobolev wrote:

> Doug Barton wrote:
>> 
>> On Wed, 15 Aug 2007, Maxim Sobolev wrote:
>> 
>>> sobomax     2007-08-15 18:35:05 UTC
>>>
>>>  FreeBSD ports repository
>>>
>>>  Modified files:
>>>    net/ser              Makefile
>>>  Added files:
>>>    net/ser/files        ser.in
>>>  Log:
>>>  Add startup script. Bump PORTREVISION.
>>>
>>>  Submitted by:   Blaz Zupan
>>>
>>>  Revision  Changes    Path
>>>  1.23      +2 -1      ports/net/ser/Makefile
>>>  1.1       +34 -0     ports/net/ser/files/ser.in (new)
>>> 
>>> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/ser/Makefile.diff?&r1=1.22&r2=1.23&f=h 
>>> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/ser/files/ser.in
>> 
>> Looks good overall. One nit, you need %%PREFIX%% instead of ${prefix}.
>
> Already there:
>
> prefix=%%PREFIX%%

That's my fault, I actually specifically looked for that and didn't find 
it.

That just changes my objection to "Pointless indirection of a one-time-use 
value." There is no reason for that to be a variable, it should just have 
%%PREFIX%% in the command= line.

Doug

-- 

     This .signature sanitized for your protection