From owner-freebsd-bugs@FreeBSD.ORG Wed Aug 29 22:40:01 2007 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A4D1316A417 for ; Wed, 29 Aug 2007 22:40:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 6EEAC13C461 for ; Wed, 29 Aug 2007 22:40:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id l7TMe1LH084571 for ; Wed, 29 Aug 2007 22:40:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.1/8.14.1/Submit) id l7TMe1em084567; Wed, 29 Aug 2007 22:40:01 GMT (envelope-from gnats) Resent-Date: Wed, 29 Aug 2007 22:40:01 GMT Resent-Message-Id: <200708292240.l7TMe1em084567@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Matthew Luckie Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DDD9216A420 for ; Wed, 29 Aug 2007 22:37:22 +0000 (UTC) (envelope-from mjl@luckie.org.nz) Received: from smtpqueue7.ihug.co.nz (smtpqueue7.ihug.co.nz [203.109.136.157]) by mx1.freebsd.org (Postfix) with ESMTP id 9E9E113C467 for ; Wed, 29 Aug 2007 22:37:22 +0000 (UTC) (envelope-from mjl@luckie.org.nz) Received: from smtp14.content.ihug.net.nz (smtp14.ihug.co.nz) [10.80.52.14] by smtpqueue7.ihug.co.nz with esmtp (Exim 4.60 #1 (Debian); Ihug conf #192) id 1IQVqY-0004eN-Gi; Thu, 30 Aug 2007 10:17:10 +1200 Received: from cust.filter1.content.ihug.net.nz (smtp.mailfilter1.ihug.co.nz) [10.80.50.1] by smtp14.ihug.co.nz with esmtp (Exim 4.60 #1 (Debian); Ihug conf #192) id 1IQVqU-0007o9-T1; Thu, 30 Aug 2007 10:17:06 +1200 Received: from 203-173-181-4.dsl.dyn.ihug.co.nz (HELO latex.plunket.luckie.org.nz) ([203.173.181.4]) by smtp.mailfilter1.ihug.co.nz with ESMTP/TLS/DHE-RSA-AES256-SHA; 30 Aug 2007 10:17:06 +1200 Received: from mjl by latex.plunket.luckie.org.nz with local (Exim 4.67 (FreeBSD)) (envelope-from ) id 1IQVqS-000HyL-Rx for FreeBSD-gnats-submit@freebsd.org; Thu, 30 Aug 2007 10:17:04 +1200 Message-Id: Date: Thu, 30 Aug 2007 10:17:04 +1200 From: Matthew Luckie Sender: Matthew Luckie To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: kern/115931: [patch] change bpf_filter() mem[] from int32_t to u_int32_t X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Matthew Luckie List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2007 22:40:01 -0000 >Number: 115931 >Category: kern >Synopsis: [patch] change bpf_filter() mem[] from int32_t to u_int32_t >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Aug 29 22:40:00 GMT 2007 >Closed-Date: >Last-Modified: >Originator: Matthew Luckie >Release: FreeBSD 6.1-RELEASE alpha >Organization: University of Waikato >Environment: System: FreeBSD latex.plunket.luckie.org.nz 6.1-RELEASE FreeBSD 6.1-RELEASE #0: Sat Jul 15 11:56:01 NZST 2006 root@:/usr/src/sys/alpha/compile/latex alpha >Description: In bpf_filter.c : bpf_filter() A and X are declared u_int32_t. mem[] is declared as int32_t. The only things that get saved or restored from mem[] are A and X. I suggest that mem[] be changed to u_int32_t to be precise about what is stored in there. I'm well aware how pedantic this is. I have compared the output for objdump -S on bpf_filter.o compiled with and without this patch on i386 and alpha on FreeBSD releases 6.2 and 6.1 respectively and there is zero change in the actual machine code generated. >How-To-Repeat: >Fix: --- bpf_filter.c.patch begins here --- --- bpf_filter.c.orig Thu Aug 30 09:48:40 2007 +++ bpf_filter.c Thu Aug 30 10:08:23 2007 @@ -186,7 +186,7 @@ { register u_int32_t A = 0, X = 0; register bpf_u_int32 k; - int32_t mem[BPF_MEMWORDS]; + u_int32_t mem[BPF_MEMWORDS]; if (pc == 0) /* --- bpf_filter.c.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: