From owner-svn-src-all@freebsd.org Wed Apr 13 03:00:25 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A30F4B0E853; Wed, 13 Apr 2016 03:00:25 +0000 (UTC) (envelope-from swills@FreeBSD.org) Received: from mouf.net (mouf.net [IPv6:2607:fc50:0:4400:216:3eff:fe69:33b3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mouf.net", Issuer "mouf.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 6E0621113; Wed, 13 Apr 2016 03:00:25 +0000 (UTC) (envelope-from swills@FreeBSD.org) Received: from [0.0.0.0] (cpe-071-065-239-148.nc.res.rr.com [71.65.239.148] (may be forged)) (authenticated bits=0) by mouf.net (8.14.9/8.14.9) with ESMTP id u3D30FPm001398 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Wed, 13 Apr 2016 03:00:21 GMT (envelope-from swills@FreeBSD.org) Subject: Re: svn commit: r297902 - head To: Ian Lepore , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201604130147.u3D1l5F0032629@repo.freebsd.org> <1460512755.52955.18.camel@freebsd.org> From: Steve Wills Message-ID: <570DB63F.9060907@FreeBSD.org> Date: Tue, 12 Apr 2016 23:00:15 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1460512755.52955.18.camel@freebsd.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mouf.net [199.48.129.64]); Wed, 13 Apr 2016 03:00:21 +0000 (UTC) X-Spam-Status: No, score=2.8 required=4.5 tests=HELO_MISC_IP, RCVD_ILLEGAL_IP, RDNS_NONE autolearn=no autolearn_force=no version=3.4.1 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mouf.net X-Virus-Scanned: clamav-milter 0.99 at mouf.net X-Virus-Status: Clean X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Apr 2016 03:00:25 -0000 On 04/12/16 09:59 PM, Ian Lepore wrote: > > More succinctly: > > .if empty(SVN) > SVN!= which svn || which svnlite > .endif > Fair enough, that's basically the intent. I think we like to avoid !=, at least in ports, and I wanted the logic between src and ports to match in this case. Steve