Date: Sun, 31 Dec 2000 12:50:23 -0800 (PST) From: sthg@hotmail.com To: freebsd-gnats-submit@FreeBSD.org Subject: kern/23987: Debug string typo Message-ID: <200012312050.eBVKoNu03852@freefall.freebsd.org> Resent-Message-ID: <200012312100.eBVL01M04452@freefall.freebsd.org>
index | next in thread | raw e-mail
>Number: 23987
>Category: kern
>Synopsis: Debug string typo
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun Dec 31 13:00:01 PST 2000
>Closed-Date:
>Last-Modified:
>Originator: Stephen Grau
>Release: 4.1-RELEASE
>Organization:
>Environment:
FreeBSD xanadu.limgrau.org 4.1-RELEASE FreeBSD 4.1-RELEASE #1: Sun Dec 31 20:45:19 EST 2000 stg@xanadu.limgrau.org:/usr/src/sys/compile/FIREWALL9 i386
>Description:
When having problems with microuptime going backwards, the symptoms look worse due to a typo in the debug message. Instead of a period, the second time is printed with a comma (in /usr/src/sys/kern/kern_synch.c). For example:
Dec 31 23:01:37 xanadu /kernel: microuptime() went backwards (688450.094451 -> 688450,-695028036)
Dec 31 23:01:37 xanadu /kernel: microuptime() went backwards (6884ckwards (688451.905274 -> 688451,885155)
Dec 31 23:01:37 xanadu /kernel: microuptime() went backwards (688451.905274 -> 688451,899963)
Dec 31 23:01:37 xanadu /kernel: microuptime() went backwards (688451.942972 -> 688451,923447)
Also note that there is at least one other bug resulting in a negative usec value, probably subtracting when it should be adding, that I was not able to find.
This comma has been a problem since 4.0 and still exists in 4.2.
>How-To-Repeat:
>Fix:
Sorry, I don't know how to do a useful diff.
/usr/src/sys/kern/$ diff kern_synch.c*
825c825
< printf("microuptime() went backwards (%ld.%06ld -> %ld.%06ld)\n",
---
> printf("microuptime() went backwards (%ld.%06ld -> %ld,%06ld)\n",
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200012312050.eBVKoNu03852>