From owner-cvs-all  Fri Jun  8  1:39:16 2001
Delivered-To: cvs-all@freebsd.org
Received: from peter3.wemm.org (c1315225-a.plstn1.sfba.home.com [65.0.135.147])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6392137B401; Fri,  8 Jun 2001 01:39:08 -0700 (PDT)
	(envelope-from peter@wemm.org)
Received: from overcee.netplex.com.au (overcee.wemm.org [10.0.0.3])
	by peter3.wemm.org (8.11.0/8.11.0) with ESMTP id f588d8M57445;
	Fri, 8 Jun 2001 01:39:08 -0700 (PDT)
	(envelope-from peter@wemm.org)
Received: from wemm.org (localhost [127.0.0.1])
	by overcee.netplex.com.au (Postfix) with ESMTP
	id 35F25380C; Fri,  8 Jun 2001 01:39:08 -0700 (PDT)
	(envelope-from peter@wemm.org)
X-Mailer: exmh version 2.3.1 01/18/2001 with nmh-1.0.4
To: obrien@FreeBSD.org
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sbin/savecore savecore.c 
In-Reply-To: <20010608005244.A2317@dragon.nuxi.com> 
Date: Fri, 08 Jun 2001 01:39:08 -0700
From: Peter Wemm <peter@wemm.org>
Message-Id: <20010608083908.35F25380C@overcee.netplex.com.au>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

"David O'Brien" wrote:
> On Thu, Jun 07, 2001 at 08:06:24PM -0700, Peter Wemm wrote:
> > peter       2001/06/07 20:06:24 PDT
> > 
> >   Modified files:
> >     sbin/savecore        savecore.c 
> >   Log:
> >   'int dumpsize; /* memory size in bytes */' is not good for machines
> >   with 2GB or more of ram.
> 
> Shouldn't the "unsigned int" have been size_t or "long" as off_t is a
> long on the Alpha.

The variable is an 'int dumpsize' in the kernel.  size_t or long are simply
not big enough to hold it - it is in pages inside the kernel and we convert
it to bytes inside savecore.  I have been Brucified on this one, so expect
some fixups soon.

Cheers,
-Peter
--
Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au
"All of this is for nothing if we don't go to the stars" - JMS/B5


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message