Date: Thu, 29 Jun 2017 03:11:51 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 219687] [NEW PORT] net/google-compute-engine: user daemon for Google Compute Engine Message-ID: <bug-219687-13-QT5DF9wsjh@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-219687-13@https.bugs.freebsd.org/bugzilla/> References: <bug-219687-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D219687 Helen Koike <helen.koike@collabora.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183895|0 |1 is obsolete| | --- Comment #5 from Helen Koike <helen.koike@collabora.com> --- Created attachment 183898 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D183898&action= =3Dedit Patch which adds google-compute-engine v2.4.0 in freebsd-ports (In reply to Richard Gallamore from comment #4) Hi Richard, thanks for reviewing this package, I am attaching a new version with the suggested changes and a few other that I found in portlint (thanks= for suggesting this, I am still getting familiar with all the FreeBSD tools) > Hey there Helen, thanks for submitting the port. After an initial scan, I= have > found a few items that need to be addressed. >=20 > - Upstream versioning is by date. Why does this not match upstream? This match upstream, it is just the github tag that is by date, the version= is in the setup.py file as shown here https://github.com/GoogleCloudPlatform/compute-image-packages/commit/5824f1= bba1906f6bb298db2efaf1bffc0671ff45 > - Add license. Done > - SUB_LIST is in USE section, should be after option section and before= target > section. Done, I added just before "post-patch:" target, is it ok now? > - In pkg-descr, WWW, please list a site with plenty of documentation and > information about the port. The git repo is lacking heavily on this. I modified this to point to the main page where the docs are https://github.com/GoogleCloudPlatform/compute-image-packages/ I think this is the most complete docs available >=20 >=20 > Can you also please post a portlint -AC and attach a poudriere build logs= if > possible. >=20 I also adjusted pkg-desc so lines don't exceed 80 characters And I removed DISTVERSION (as it cannot be user with PORTVERSION) -PORTVERSION=3D 2.4.0 -DISTVERSION=3D 20170609 +PORTVERSION=3D 20170609 But now it uses version 20170609 instead of 2.4.0, is this ok? I feel that 2.4.0 should be somewhere as it is the version used in setup.py, what do you think? I tried to use GH_TAGNAME=3D20170609 with PORTVERSION=3D2.4.0 but it doesn'= t seem to work the way I imagined. With these changes now portlint returns: # portlint -AC looks fine. I'm attaching the poudriere logs in the comment that follows Thanks for your help --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-219687-13-QT5DF9wsjh>