From owner-freebsd-ports-bugs@freebsd.org Thu Jun 29 03:11:52 2017 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 17F4ED8FA27 for ; Thu, 29 Jun 2017 03:11:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E38C772582 for ; Thu, 29 Jun 2017 03:11:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5T3BpFp023503 for ; Thu, 29 Jun 2017 03:11:51 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 219687] [NEW PORT] net/google-compute-engine: user daemon for Google Compute Engine Date: Thu, 29 Jun 2017 03:11:51 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: helen.koike@collabora.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.isobsolete attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jun 2017 03:11:52 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D219687 Helen Koike changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183895|0 |1 is obsolete| | --- Comment #5 from Helen Koike --- Created attachment 183898 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D183898&action= =3Dedit Patch which adds google-compute-engine v2.4.0 in freebsd-ports (In reply to Richard Gallamore from comment #4) Hi Richard, thanks for reviewing this package, I am attaching a new version with the suggested changes and a few other that I found in portlint (thanks= for suggesting this, I am still getting familiar with all the FreeBSD tools) > Hey there Helen, thanks for submitting the port. After an initial scan, I= have > found a few items that need to be addressed. >=20 > - Upstream versioning is by date. Why does this not match upstream? This match upstream, it is just the github tag that is by date, the version= is in the setup.py file as shown here https://github.com/GoogleCloudPlatform/compute-image-packages/commit/5824f1= bba1906f6bb298db2efaf1bffc0671ff45 > - Add license. Done > - SUB_LIST is in USE section, should be after option section and before= target > section. Done, I added just before "post-patch:" target, is it ok now? > - In pkg-descr, WWW, please list a site with plenty of documentation and > information about the port. The git repo is lacking heavily on this. I modified this to point to the main page where the docs are https://github.com/GoogleCloudPlatform/compute-image-packages/ I think this is the most complete docs available >=20 >=20 > Can you also please post a portlint -AC and attach a poudriere build logs= if > possible. >=20 I also adjusted pkg-desc so lines don't exceed 80 characters And I removed DISTVERSION (as it cannot be user with PORTVERSION) -PORTVERSION=3D 2.4.0 -DISTVERSION=3D 20170609 +PORTVERSION=3D 20170609 But now it uses version 20170609 instead of 2.4.0, is this ok? I feel that 2.4.0 should be somewhere as it is the version used in setup.py, what do you think? I tried to use GH_TAGNAME=3D20170609 with PORTVERSION=3D2.4.0 but it doesn'= t seem to work the way I imagined. With these changes now portlint returns: # portlint -AC looks fine. I'm attaching the poudriere logs in the comment that follows Thanks for your help --=20 You are receiving this mail because: You are the assignee for the bug.=