Date: Thu, 22 Jul 2010 19:40:04 GMT From: Niels Heinen <niels@FreeBSD.org> To: ports@FreeBSD.org Subject: Re: ports/147935: [MAINTAINER] security/botan: update to 1.8.9 Message-ID: <201007221940.o6MJe42U037325@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/147935; it has been noted by GNATS. From: Niels Heinen <niels@FreeBSD.org> To: Lapo Luchini <lapo@lapo.it> Cc: bug-followup@FreeBSD.org Subject: Re: ports/147935: [MAINTAINER] security/botan: update to 1.8.9 Date: Thu, 22 Jul 2010 21:30:01 +0200 Hi Lapo, sorry for delaying this one. I lack the time to follow up and threw the PR back in the pool. Niels On 06/30/10 15:11, Lapo Luchini wrote: > I asked the author (Jack Lloyd) about that, and that's what he told me: > >> It only shows up on 32 bit compilations. It's actually caused by a bug >> in GCC, fixed in 4.5.0 (PR 13358). It seems strange to me that this >> would be 'too many' warnings - it's effectively one warning. >> >> There is no actual functionality problem that this warning is pointing >> out; GCC is still doing exactly the right thing, just printing an >> obnoxious warning for every 64-bit constant it sees that is impossible >> to disable via a -Wno-obnoxious-warning flag. The workaround is to >> append ULL to each of the constants. I don't want to do that upstream >> because every other compiler accepts them without any suffix, but some >> Windows compilers will reject the suffixed version. > > I wonder if it's the best approach to have a hundreds' line patch adding > ULLs to a DES cryptographic routine only to silence warnings that > produce no problems (except spamming the console, of course!). > > IMHO it's probably better to avoid that, but I can put some clever > inline-sed code to add them, if you think that's really necessary. > > PS: it would probably be nice to add LICENSE lines in the Makefile > though, as in the attached patch. -- Niels Heinen FreeBSD committer | www.freebsd.org PGP: 0x5FE39B80
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201007221940.o6MJe42U037325>