From nobody Sun Aug 20 02:57:11 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RT0dM5mYXz4qb5f; Sun, 20 Aug 2023 02:57:11 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RT0dM5C7Dz4JZn; Sun, 20 Aug 2023 02:57:11 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692500231; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=K0V83IqmXOcL4PgUippEn6KvIcpa1+vbB5bZTxZw+/M=; b=HhOXTb7tM77PtlNbLV/x9L9lo1d0ScWgAl107cfhhhD3i4q4YYA9SKPzGM2xJgiJvzLOFf 6G/FR5h0tiLYnAYkLTHySNy3FNTb/fT9XFq3XAMeEkSzVu/hpEUEnGhuQlj1L1o3NnxTTZ jFoUFCBQLpOtCgGyzJ4XtEGoG3Vz44MNK7znAfDyQXr/NQcIK0BIAgY+wGrIdwTCkUcCrn qQcrAPyJocYqEteOw9f6AIXI/KGjaEI94f/ieZT0pf1z5Qf3eExzel7GkllELNXsAwUYRw DEl4MdGzMj0d2duSDg43rYXF8eliiCuSI189JkTr0jSOVM1jzEhDkh/29bA1EQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692500231; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=K0V83IqmXOcL4PgUippEn6KvIcpa1+vbB5bZTxZw+/M=; b=HhBzR/eh+3jKjAfHqYq3Wsh7bpnxoVPGOxVZ77d34G1EsVSHcYvQhP3+o8H46wn/TrtAnX FEOyFRgE9Ra759aTv9Bf8EAZB/dxf4RU28HMAI+KHkEtMIpkvi+8wpMYhlkphq4cxTFsat 14pWR25qv4yBs8KVq+ri6afIANYkmxVjFA7SC9Rksh+X4Rg6ivHNetBc844Ll+69EH3Ter kwtOvX+skYxiyr4LyvkTQiQPjIuTG9MGAucOm+uBVRaat/Yr9M2rYLDF66hmKiWvMWKUqE 5qLmkACSbh3uyb4nYIt98Y6jCHXEemnx+rMMcl6/cVWgl/O/iduNKqgv5PMY5g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1692500231; a=rsa-sha256; cv=none; b=mwz/T9hYnBFV5ouM0Z8qZEVxba/4ea8uGcRU/OoZdYwguFxWhLp3L9KeaM5X3djjPKzWyg D86gnwdDPcicfe0tQ5oDlgjMqMbbdh7kG5yRQwNtJotzI7llADBjtgUHdvwF1i2i+rKcMI DV5ZAlkDyBxYxFEA86BhYm3tZToiOEXRG9MBs6TbTWZ5VOwcXFd6aHiNXpnkVWAyqsrDG1 oijRi/xFDFSCJ3uy6ILDzqyMOeSbVTNYfBg4p7bbdKPWyPfo37PytMemdu5pR2WM/HMnKm HQDNy8uEOoT3ucPpl1dd9UO2lHi4yvbHnwA0c5lGISYRB+f4n79ZAO1Mkds1+g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: by freefall.freebsd.org (Postfix, from userid 1033) id 767821477F; Sun, 20 Aug 2023 02:57:11 +0000 (UTC) Date: Sun, 20 Aug 2023 02:57:11 +0000 From: Alexey Dokuchaev To: Jan Beich Cc: Daniel Engberg , Po-Chuan Hsieh , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 616e8c13a4ce - main - devel/utf8cpp: Update to 3.2.4 Message-ID: References: <202308161944.37GJifUD062454@gitrepo.freebsd.org> <5be35ca3e7ac2390fdbce2e4792223b5@pyret.net> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Aug 19, 2023 at 09:09:14AM +0200, Jan Beich wrote: > Daniel Engberg writes: > > On 2023-08-16 21:44, Po-Chuan Hsieh wrote: > >> --- a/devel/utf8cpp/Makefile > >> +++ b/devel/utf8cpp/Makefile > >> @@ -1,9 +1,9 @@ > >> PORTNAME= utf8cpp > >> +PORTVERSION= 3.2.4 > >> DISTVERSIONPREFIX= v > >> -DISTVERSION= 3.2.3 > [...] > > Can you please revert you changes so the port don't deviate from > > Porters Handbook? > > https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github > > - Example 16 > > Did you overquote the whole commit just for DISTVERSION vs. PORTVERSION? Overquoting is a big problem these days, unfortunately. Alas, few of us seem to care. :( Regarding this commit, for 3.2.4, both PORTVERSION and DISTVERSION could be used, with PORTVERSION bearing less cognitive load on the reader IMO. Knob order matter is minuscule in this particular case. The only "real" issue here is uglified pkg-descr: now the right edge is rugged and touches 80-char limit while we typically leave some padding, exact number of spaces depends on the best text alignment (and one's taste; we're lacking in that department as well). ./danfe