From owner-svn-src-head@freebsd.org  Sat May  2 09:16:35 2020
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id AB3C92C9876;
 Sat,  2 May 2020 09:16:35 +0000 (UTC)
 (envelope-from rene@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 49Dk5H42Mjz3y0H;
 Sat,  2 May 2020 09:16:35 +0000 (UTC)
 (envelope-from rene@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1185)
 id 6440C5D4F; Sat,  2 May 2020 09:16:35 +0000 (UTC)
Date: Sat, 2 May 2020 09:16:35 +0000
From: Rene Ladan <rene@freebsd.org>
To: Warner Losh <imp@freebsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r360540 - head/stand/libofw
Message-ID: <20200502091635.GA16751@freefall.freebsd.org>
References: <202005011750.041HoMaV058949@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <202005011750.041HoMaV058949@repo.freebsd.org>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 02 May 2020 09:16:35 -0000

On Fri, May 01, 2020 at 05:50:22PM +0000, Warner Losh wrote:
> Author: imp
> Date: Fri May  1 17:50:21 2020
> New Revision: 360540
> URL: https://svnweb.freebsd.org/changeset/base/360540
> 
> Log:
>   Remove more stray sparc64 ifdefs.
>   
>   Also, dmabuf appears to only be set for sparc64 case, but there was a
>   comment at its only use that says it was broken for some apple
>   adapters. #ifdef it all of that out now that nothing sets it.
> 
> Modified:
>   head/stand/libofw/ofw_net.c
> 
> Modified: head/stand/libofw/ofw_net.c
> ==============================================================================
> --- head/stand/libofw/ofw_net.c	Fri May  1 17:17:01 2020	(r360539)
> +++ head/stand/libofw/ofw_net.c	Fri May  1 17:50:21 2020	(r360540)
[...]
> @@ -220,20 +220,6 @@ ofwn_init(struct iodesc *desc, void *machdep_hint)
>  #if defined(NETIF_DEBUG)
>  	printf("ofwn_init: Open Firmware instance handle: %08x\n", netinstance);
>  #endif
> -
> -#ifndef __sparc64__
      ^
Shouldn't this code always be present?
> -	dmabuf = NULL;
> -	if (OF_call_method("dma-alloc", netinstance, 1, 1, (64 * 1024), &dmabuf)
> -	    < 0) {   
> -		printf("Failed to allocate DMA buffer (got %p).\n", dmabuf);
> -		goto punt;
> -	}
> -
> -#if defined(NETIF_DEBUG)
> -	printf("ofwn_init: allocated DMA buffer: %p\n", dmabuf);
> -#endif
> -#endif
> -

René