From owner-svn-src-all@FreeBSD.ORG Wed Dec 10 23:30:57 2008 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6EAAF106564A; Wed, 10 Dec 2008 23:30:57 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 248808FC08; Wed, 10 Dec 2008 23:30:57 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id mBANS6FT021276; Wed, 10 Dec 2008 16:28:06 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Wed, 10 Dec 2008 16:28:17 -0700 (MST) Message-Id: <20081210.162817.474623206.imp@bsdimp.com> To: jhb@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <200812101945.mBAJjwn2040853@svn.freebsd.org> References: <200812101945.mBAJjwn2040853@svn.freebsd.org> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r185874 - head/sys/sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Dec 2008 23:30:57 -0000 In message: <200812101945.mBAJjwn2040853@svn.freebsd.org> John Baldwin writes: : Author: jhb : Date: Wed Dec 10 19:45:58 2008 : New Revision: 185874 : URL: http://svn.freebsd.org/changeset/base/185874 : : Log: : Rather than using a char array with explicit assumptions about the layout : of 'struct osigevent' in 'struct aiocb', use int and void pointer spare : members that are identical to 'struct osigevent'. This is better from an alignment perspective for !intel architectures. warner : MFC after: 1 month : : Modified: : head/sys/sys/aio.h : : Modified: head/sys/sys/aio.h : ============================================================================== : --- head/sys/sys/aio.h Wed Dec 10 19:33:10 2008 (r185873) : +++ head/sys/sys/aio.h Wed Dec 10 19:45:58 2008 (r185874) : @@ -69,7 +69,8 @@ typedef struct aiocb { : off_t aio_offset; /* File offset for I/O */ : volatile void *aio_buf; /* I/O buffer in process space */ : size_t aio_nbytes; /* Number of bytes for I/O */ : - char __spare__[sizeof(int) * 2 + sizeof(void *)]; /* osigevent. */ : + int __spare__[2]; : + void *__spare2__; : int aio_lio_opcode; /* LIO opcode */ : int aio_reqprio; /* Request priority -- ignored */ : struct __aiocb_private _aiocb_private; :