From nobody Sun Dec 24 15:50:14 2023 X-Original-To: desktop@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SylqC2Vnmz54njW for ; Sun, 24 Dec 2023 15:50:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SylqC1QcRz4Q3B for ; Sun, 24 Dec 2023 15:50:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1703433015; a=rsa-sha256; cv=none; b=UMA8JtrXRRb3rqhMKwTl76IJIxvc6KiLGPZlolf15BV/enCm5xd9QjRaRR73I7l4R35jQ7 vr3cCGqODqM4FHoiumX1OEeyL43n4dLihy4zzpJH6A5Z3S7E9QzrqQvaMKC+5VucuQFN9x cN+B/X9VRKShcDXoE+0M05UvQDVIShVtSvGSV8f2MOc7hM6+DJiYcQqhnPxbC9kV/YYfTv +McUiQZ6l4R9Cb2kocWaqjX92s7B7Xr+ehmuMKsm97qizyFg7kRo9aUHpVvrtTZpcy/CR+ xzWy48BaLRAu2Xl4A6HaAo9p7w5uRCuXXTMgKhICzkUcRbadbs9+x4HsaLtKfg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1703433015; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/GsxrFSZ/dPEvschzofKUwAiA5an2FMPyxVU2AUZdzk=; b=aEJ4soo377STA2DSoDSVeO8Whgvy+rYP2DeauhXC9anOOdgoqw3taafCAYAJGOyMRFABPU 6zaNuWlVFh92nKWCR5MIJwzduNoEU6CdIO7ACXE9t0OktfDKC7UEapJnQQLdzoBd6YzLEM 0hV6dkHrDBEQMlK5n1pJTvpcl71MntXFrdQceP4LOjWJVlZ5HhClYXtHWGpvR37LmjDqYZ 7pDO3WAnUvU/8nsQcSix2CTPmWx3kNrec293kjKNjztGvIJbnYRlJK/QPz56ZnQWXxkvlq +cF/kt+6X5VOSVTZnt2/EKikROqb2Tp/s9ojl5GQNTaIzLAmjALuSS95GFIHOQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SylqC0V0jzZCR for ; Sun, 24 Dec 2023 15:50:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3BOFoFkG098036 for ; Sun, 24 Dec 2023 15:50:15 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3BOFoFQ6098035 for desktop@FreeBSD.org; Sun, 24 Dec 2023 15:50:15 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: desktop@FreeBSD.org Subject: [Bug 266532] x11/lightdm: Login sessions do not respect login.conf Date: Sun, 24 Dec 2023 15:50:14 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-patch, needs-qa X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: tamelingdaniel@gmail.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: desktop@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Using and improving FreeBSD on the desktop List-Archive: https://lists.freebsd.org/archives/freebsd-desktop List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-desktop@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D266532 --- Comment #22 from Daniel Tameling --- There is one minor issue left: you didn't remove the original execve call, = so that the new one with environ is never reached. When I delete the first exe= cve, it works as expected. Another thing to think about is that files/patch-src_session-child.c patches the PATH: - pam_putenv (pam_handle, "PATH=3D/usr/local/bin:/usr/bin:/bin"); + pam_putenv (pam_handle, "PATH=3D/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:~/bin"= ); This doesn't have any effect since we call setusercontext later, so one cou= ld completely drop it. At the very least I would do something about the ~/bin, since this won't get expanded and is a literal ~. If one wants to keep the line, one could just delete the last component of the PATH or expand the ~ manually with the HOME directory we get a few lines later. There are also some trailing whitespaces in the patch: patch_v2:122: trailing whitespace. patch_v2:132: trailing whitespace. @@ -48,7 +48,7 @@ AC_CHECK_HEADERS(gcrypt.h, [], AC_MSG_ERROR(libgcrypt patch_v2:133: trailing whitespace. patch_v2:135: trailing whitespace. patch_v2:138: trailing whitespace. warning: squelched 8 whitespace errors warning: 13 lines add whitespace errors. --=20 You are receiving this mail because: You are the assignee for the bug.=