From owner-freebsd-ports@FreeBSD.ORG Tue Nov 30 14:59:51 2010 Return-Path: Delivered-To: ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A613C106566C; Tue, 30 Nov 2010 14:59:51 +0000 (UTC) (envelope-from linimon@lonesome.com) Received: from mail.soaustin.net (pancho.soaustin.net [76.74.250.40]) by mx1.freebsd.org (Postfix) with ESMTP id 86FA48FC08; Tue, 30 Nov 2010 14:59:51 +0000 (UTC) Received: by mail.soaustin.net (Postfix, from userid 502) id 1AD9E56026; Tue, 30 Nov 2010 14:59:51 +0000 (UTC) Date: Tue, 30 Nov 2010 14:59:51 +0000 From: Mark Linimon To: Ade Lovett Message-ID: <20101130145951.GA24687@lonesome.com> References: <20101130041323.GA17404@lonesome.com> <5A25461F-A28C-415C-A8AB-59C91E1B1CC7@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5A25461F-A28C-415C-A8AB-59C91E1B1CC7@FreeBSD.org> User-Agent: Mutt/1.5.18 (2008-05-17) Cc: FreeBSD Ports Subject: Re: CFR: patch to cleanup usage of SRC_BASE in various ports X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Nov 2010 14:59:51 -0000 On Tue, Nov 30, 2010 at 03:33:27AM -0600, Ade Lovett wrote: > Seems like there's an awful lot of duplication of: > > SRC_BASE?= /usr/src > > in those port Makefiles. > > What's wrong with adding the above, with a bit of documentation, to > bsd.port.mk ? Nothing at all, but this is a fix I'd like to go ahead and get in ASAP, as it's holding me up from doing what I need to do. mcl