From owner-svn-src-head@freebsd.org Sat Jul 8 17:16:46 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 94DC0D9ED03; Sat, 8 Jul 2017 17:16:46 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-wr0-x22a.google.com (mail-wr0-x22a.google.com [IPv6:2a00:1450:400c:c0c::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 242312A05; Sat, 8 Jul 2017 17:16:46 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: by mail-wr0-x22a.google.com with SMTP id r103so85939127wrb.0; Sat, 08 Jul 2017 10:16:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=bewFH+PMUviZ3/jqsNOBBUjiVpxpJdhTG9LgaKUg9sw=; b=tqeVfVZPanL51XorOnVlnH5cZb66nQL69tTBp5rVMTG/jlzipYdMtEKU5njXIvVW+m 4OSThqVt9C+omx48Noxge2YTx8nk8bz8ry3QHxyzmcHK9LL4CMdlLZtOime/RxDeVdU5 5gFNCS2VVQhrvU4yEKhWK7V6JyCsTZHAEM09h/NlaC+sIdq5cSI+lDwx8Yb9robet6Pc j+ddjCdUPT0LVsJCeHrGUFndo/nQprpSJvCe5RVUr93nYVmQJsFuMIjdKhj9KOwgKvl8 ESii3U/XEOSzmq88eOm8pfTepFnrB/7I+SVjOJUmHtm3Mj6rQ7t3zjnKa1aKOsdGvBOq IBSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=bewFH+PMUviZ3/jqsNOBBUjiVpxpJdhTG9LgaKUg9sw=; b=TVtgDGV6npHcbqore8cQ64QjjWTHTlei6HG/0rfcvDXgIJZ278QsfAXBApSXJuMlo0 JsA0/+LTMQYUXCHShDhKGJMClLytzGNG0rH2325mob6FnHKa6fx16JAjE9NNeGig9hoz epbeiYKsxpGragXdTRcgODS9X9SSkEGWIaSGgW5w3QxYJe+m1fbXz6AKF6fhP+u6f0xK 9VGjAhg2io0lkHgy75RRs2qH/HmYIxTZ/88lxZgKAA7kQ5hCz0AD4DKhGiDh8VgvYNxz H2PHMLD9u4lL9N3wKlkn3KqpgXAhmVJ9vE5ZBQPHbdSaClM1+HngNQhINTvRpgdnvo3y RUdw== X-Gm-Message-State: AIVw113WQTU3O+8WVYL6QCyBrZagX0UOx3SNaiRJ8DV5YecVxZ1xE//1 r6TshZM/vvp8aGI9 X-Received: by 10.28.107.131 with SMTP id a3mr2804403wmi.60.1499534204220; Sat, 08 Jul 2017 10:16:44 -0700 (PDT) Received: from brick (cpc92310-cmbg19-2-0-cust934.5-4.cable.virginm.net. [82.9.227.167]) by smtp.gmail.com with ESMTPSA id r191sm2186849wmg.6.2017.07.08.10.16.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 08 Jul 2017 10:16:43 -0700 (PDT) Sender: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= Date: Sat, 8 Jul 2017 18:16:41 +0100 From: Edward Tomasz Napierala To: Ian Lepore Cc: rgrimes@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r320803 - head/sbin/mount Message-ID: <20170708171641.GA1129@brick> Mail-Followup-To: Ian Lepore , rgrimes@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201707081650.v68GoHgS068308@pdx.rh.CN85.dnsmgr.net> <1499533357.87595.78.camel@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1499533357.87595.78.camel@freebsd.org> User-Agent: Mutt/1.8.2 (2017-04-18) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Jul 2017 17:16:46 -0000 On 0708T1102, Ian Lepore wrote: > On Sat, 2017-07-08 at 09:50 -0700, Rodney W. Grimes wrote: > > [ Charset UTF-8 unsupported, converting... ] > > > > > > Author: trasz > > > Date: Sat Jul  8 11:06:27 2017 > > > New Revision: 320803 > > > URL: https://svnweb.freebsd.org/changeset/base/320803 > > > > > > Log: > > >   Fix "mount -uw /" when the filesystem type doesn't match. > > >    > > >   This basically makes "mount -uw /" work when the filesystem > > >   mounted on / is NFS, but the one configured in fstab(5) is UFS, > > >   which can happen when you forget to modify fstab. > > Please do not silence user errors because they are inconvinient, > > this is a configuration error and the system should fail to  > > mount the incorrectly configured root. > > > > If we start changing things to silently ignore user configuration > > errors we are going down a very slippery road. It doesn't silence down the error. What it does is it makes it possible to use "mount -uw /" - previously it would fail in a rather nonsensical way, by calling "mount_nfs -o upgrade,rw /dev/ada0 /". > IMO, this change fixes the right problem, but maybe does so the wrong > way.  Mount -u is by definition an update to an existing mount.  There > should be no need to consult /etc/fstab for an existing mount since the > info is available from the kernel. > > Note that I say the foregoing with my user hat on.  I haven't looked at > the code to see if there's some reason why my common-sensical way of > thinking about it is actually impossible to implement for some reason. I wouldn't expect it to consult fstab either, to be honest. But it does, and I suspect changing that would break someone's config.