From owner-freebsd-bugs@FreeBSD.ORG Fri Sep 21 02:00:16 2007 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 32F7F16A417 for ; Fri, 21 Sep 2007 02:00:16 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 20D3D13C455 for ; Fri, 21 Sep 2007 02:00:16 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id l8L20Fdl067671 for ; Fri, 21 Sep 2007 02:00:15 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.1/8.14.1/Submit) id l8L20F9l067670; Fri, 21 Sep 2007 02:00:15 GMT (envelope-from gnats) Date: Fri, 21 Sep 2007 02:00:15 GMT Message-Id: <200709210200.l8L20F9l067670@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: vehemens Cc: Subject: Re: kern/114688: [drm] RADEON/AIGLX/DRM Problem X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: vehemens List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Sep 2007 02:00:16 -0000 The following reply was made to PR kern/114688; it has been noted by GNATS. From: vehemens To: bug-followup@freebsd.org, vehemens@verizon.net Cc: Subject: Re: kern/114688: [drm] RADEON/AIGLX/DRM Problem Date: Thu, 20 Sep 2007 18:56:09 -0700 Revised 7-current patch with Jung-uk Kim's style fixes. --- drm_drv.c.orig 2006-09-07 16:04:47.000000000 -0700 +++ drm_drv.c 2007-09-20 12:20:24.000000000 -0700 @@ -711,6 +711,9 @@ return EINVAL; } + if (--priv->refs != 0) + goto done; + if (dev->driver.preclose != NULL) dev->driver.preclose(dev, filp); @@ -786,17 +789,17 @@ dev->buf_pgid = 0; #endif /* __NetBSD__ || __OpenBSD__ */ - if (--priv->refs == 0) { - if (dev->driver.postclose != NULL) - dev->driver.postclose(dev, priv); - TAILQ_REMOVE(&dev->files, priv, link); - free(priv, M_DRM); - } + + if (dev->driver.postclose != NULL) + dev->driver.postclose(dev, priv); + TAILQ_REMOVE(&dev->files, priv, link); + free(priv, M_DRM); /* ======================================================== * End inline drm_release */ +done: atomic_inc( &dev->counts[_DRM_STAT_CLOSES] ); #ifdef __FreeBSD__ device_unbusy(dev->device);