From owner-freebsd-current  Thu Oct  1 00:14:18 1998
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id AAA02190
          for freebsd-current-outgoing; Thu, 1 Oct 1998 00:14:18 -0700 (PDT)
          (envelope-from owner-freebsd-current@FreeBSD.ORG)
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.15.68.22])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id AAA02185
          for <current@FreeBSD.ORG>; Thu, 1 Oct 1998 00:14:12 -0700 (PDT)
          (envelope-from bde@godzilla.zeta.org.au)
Received: (from bde@localhost)
	by godzilla.zeta.org.au (8.8.7/8.8.7) id RAA28403;
	Thu, 1 Oct 1998 17:13:41 +1000
Date: Thu, 1 Oct 1998 17:13:41 +1000
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199810010713.RAA28403@godzilla.zeta.org.au>
To: peter@netplex.com.au, seggers@semyam.dinoco.de
Subject: Re: Building elf kernel
Cc: current@FreeBSD.ORG, jdp@polstra.com
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

>> Back in june, he made the #include <machine/asmacros.h> in globals.s 
>> dependent on !SMP.  This caused the SMP + ELF code to miss the #defines 
>
>Could it be that this test should have been the other way round (only
>do the include when we use SMP) and around #include <machine/pmap.h>
>instead?  I took a look at it and I think then it would make sense and

No.  <machine/asmacros.h> is normally included to get the definition
of ALIGN_DATA.  This definition is only used in the !SMP case.
Unfortunately, for elf, <machine/asmacros.h> also has to be included
for its side effect of including <machine/asnames.h>.

Bruce

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message