From owner-cvs-all@FreeBSD.ORG  Fri Aug 19 08:53:32 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 77E4716A41F;
	Fri, 19 Aug 2005 08:53:32 +0000 (GMT)
	(envelope-from stefan@fafoe.narf.at)
Received: from viefep16-int.chello.at (viefep16-int.chello.at [213.46.255.17])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 09D2543D48;
	Fri, 19 Aug 2005 08:53:30 +0000 (GMT)
	(envelope-from stefan@fafoe.narf.at)
Received: from wombat.fafoe.narf.at ([213.47.85.26]) by viefep16-int.chello.at
	(InterMail vM.6.01.04.04 201-2131-118-104-20050224) with ESMTP id
	<20050819085328.CYMG1647.viefep16-int.chello.at@wombat.fafoe.narf.at>;
	Fri, 19 Aug 2005 10:53:28 +0200
Received: by wombat.fafoe.narf.at (Postfix, from userid 1001)
	id 25801F6; Fri, 19 Aug 2005 10:53:28 +0200 (CEST)
Date: Fri, 19 Aug 2005 10:53:27 +0200
From: Stefan Farfeleder <stefanf@FreeBSD.org>
To: Doug Barton <dougb@FreeBSD.org>
Message-ID: <20050819085325.GT21905@wombat.fafoe.narf.at>
References: <200508190356.j7J3uj5D095435@repoman.freebsd.org>
	<43059925.3090701@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <43059925.3090701@FreeBSD.org>
User-Agent: Mutt/1.5.9i
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/conf newvers.sh
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Aug 2005 08:53:32 -0000

On Fri, Aug 19, 2005 at 01:32:37AM -0700, Doug Barton wrote:

> 1. A "better" way (IMO) to write:
> 
> if [ "X${BRANCH_OVERRIDE}" != "X" ]; then
> 
> is
> 
> case "${BRANCH_OVERRIDE}" in
> '')	;;
> *)	BRANCH=${BRANCH_OVERRIDE} ;;
> esac
> 
> The original reason for writing it this way was to avoid the call to 
> test(1), because case is a shell builtin. This is a style issue, and not a 
> "must have," but I thought I'd mention it.

[ is a shell built-in too.

Stefan