From owner-freebsd-doc@FreeBSD.ORG Thu May 5 09:30:07 2005 Return-Path: Delivered-To: freebsd-doc@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 75D2116A4CE for ; Thu, 5 May 2005 09:30:07 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3963F43DA6 for ; Thu, 5 May 2005 09:30:07 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j459U2ug082492 for ; Thu, 5 May 2005 09:30:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j459U289082491; Thu, 5 May 2005 09:30:02 GMT (envelope-from gnats) Resent-Date: Thu, 5 May 2005 09:30:02 GMT Resent-Message-Id: <200505050930.j459U289082491@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-doc@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, vd@datamax.bg Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7462016A4CE for ; Thu, 5 May 2005 09:26:38 +0000 (GMT) Received: from jengal.datamax.bg (jengal.datamax.bg [82.103.104.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1BCFC43D7B for ; Thu, 5 May 2005 09:26:38 +0000 (GMT) (envelope-from vd@datamax.bg) Received: from sinanica.bg.datamax (sinanica.bg.datamax [192.168.10.1]) by jengal.datamax.bg (Postfix) with QMQP id 34B8C87E3 for ; Thu, 5 May 2005 12:26:32 +0300 (EEST) Received: (nullmailer pid 15684 invoked by uid 1004); Thu, 05 May 2005 09:26:32 -0000 Message-Id: <20050505092632.GA15619@sinanica.bg.datamax> Date: Thu, 5 May 2005 12:26:32 +0300 From: Vasil Dimov To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: docs/80650: Wrong sed arguments in command for CRLF->LF conversion in porters-handbook X-BeenThere: freebsd-doc@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: vd@datamax.bg List-Id: Documentation project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2005 09:30:07 -0000 >Number: 80650 >Category: docs >Synopsis: Wrong sed arguments in command for CRLF->LF conversion in porters-handbook >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-doc >State: open >Quarter: >Keywords: >Date-Required: >Class: doc-bug >Submitter-Id: current-users >Arrival-Date: Thu May 05 09:30:02 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Vasil Dimov >Release: FreeBSD 5.4-STABLE i386 >Organization: DataMax >Environment: System: FreeBSD sinanica.bg.datamax 5.4-STABLE FreeBSD 5.4-STABLE #5: Mon Apr 11 14:07:32 EEST 2005 root@sinanica.bg.datamax:/usr/obj/usr/src/sys/SINANICA-SMP i386 >Description: The command given in the "4.4 Patching" chapter of the porters-handbook as a way to convert CRLF line endings (dos format) to LF (unix) uses sed's -e argument when it is not needed (only one sed command) and misses -E argument when it is needed to interpret the regexp as an extended regular expression. NOTE: this patch assumes patch from docs/80649 is already applied. >How-To-Repeat: >Fix: --- en_US.ISO8859-1/books/porters-handbook/book.sgml.orig Thu May 5 12:18:55 2005 +++ en_US.ISO8859-1/books/porters-handbook/book.sgml Thu May 5 12:19:01 2005 @@ -694,7 +694,7 @@ post-extract: @${FIND} -E ${WRKDIR} -type f -iregex ".*\.(c|cpp|h|txt)" -print0 | \ - ${XARGS} -0 ${REINPLACE_CMD} -e 's/[[:cntrl:]]*$$//' + ${XARGS} -0 ${REINPLACE_CMD} -E 's/[[:cntrl:]]*$$//' Of course, if you need to process each and every file, above can be omitted. Be aware that this >Release-Note: >Audit-Trail: >Unformatted: