From owner-svn-ports-all@freebsd.org  Tue Mar  1 10:32:32 2016
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7FF41ABECD5;
 Tue,  1 Mar 2016 10:32:32 +0000 (UTC)
 (envelope-from gahr@FreeBSD.org)
Received: from mail.ptrcrt.ch (gahr.cloud.tilaa.com [84.22.109.158])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4E8CC13DD;
 Tue,  1 Mar 2016 10:32:29 +0000 (UTC)
 (envelope-from gahr@FreeBSD.org)
Received: from webmail.ptrcrt.ch (www.gahr.ch [192.168.1.2])
 by mail.ptrcrt.ch (OpenSMTPD) with ESMTPSA id e6f610f3
 TLS version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO; 
 Tue, 1 Mar 2016 10:32:24 +0000 (UTC)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Tue, 01 Mar 2016 11:32:24 +0100
From: Pietro Cerutti <gahr@FreeBSD.org>
To: Mathieu Arnold <mat@freebsd.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org, owner-ports-committers@freebsd.org
Subject: Re: svn commit: r409855 - in head: lang/tcl86 lang/tcl86/files
 x11-toolkits/tk86
Organization: The FreeBSD Project
In-Reply-To: <6C71D4ECCA17E729D8CA7F38@atuin.in.mat.cc>
References: <201603010931.u219VhfM013833@repo.freebsd.org>
 <6C71D4ECCA17E729D8CA7F38@atuin.in.mat.cc>
Message-ID: <700ef31768041a75d192c1703530eead@gahr.ch>
X-Sender: gahr@FreeBSD.org
User-Agent: Roundcube Webmail/1.1.4
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Mar 2016 10:32:32 -0000

On 2016-03-01 10:58, Mathieu Arnold wrote:
> +--On 1 mars 2016 09:31:43 +0000 Pietro Cerutti <gahr@FreeBSD.org> 
> wrote:
> | +TEST_TARGET=	do-test
> 
> That should not be needed, the fact that you have a do-test target will
> have "make test" work the right way.
> 
> | +TCLMAN_VARS=	INSTALL_TARGET+=install-doc
> | +TZDATA_VARS=	INSTALL_TARGET+=install-tzdata
> | +MODULES_VARS=	INSTALL_TARGET+=install-modules
> 
> These three should be written as:
> 
> TCLMAN_INSTALL_TARGET=install-doc
> TZDATA_INSTALL_TARGET=install-tzdata
> MODULES_INSTALL_TARGET=install-modules
> 
> instead of using the _VARS construct.  The porter's handbook do say, in 
> red:
> 
>         Before using OPT_VARS and OPT_VARS_OFF, see if there is already 
> a
>         more specific helper available
> 
> With a link to the correct section.
> 
> | +.include <bsd.port.options.mk>
> 
> You can drop this if you use the post-patch-TCLMAN-off: target.

All applied, thank you!

-- 
Pietro Cerutti
gahr@FreeBSD.org