From owner-svn-src-head@FreeBSD.ORG  Fri Apr 29 07:11:09 2011
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C6BE6106566B;
	Fri, 29 Apr 2011 07:11:09 +0000 (UTC)
	(envelope-from bschmidt@techwires.net)
Received: from mail-bw0-f54.google.com (mail-bw0-f54.google.com
	[209.85.214.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 03E748FC0C;
	Fri, 29 Apr 2011 07:11:08 +0000 (UTC)
Received: by bwz12 with SMTP id 12so4145625bwz.13
	for <multiple recipients>; Fri, 29 Apr 2011 00:11:07 -0700 (PDT)
Received: by 10.204.81.196 with SMTP id y4mr325426bkk.111.1304061032855;
	Fri, 29 Apr 2011 00:10:32 -0700 (PDT)
Received: from jessie.localnet (p5B2ECD51.dip0.t-ipconnect.de [91.46.205.81])
	by mx.google.com with ESMTPS id
	c11sm1433337bkc.14.2011.04.29.00.10.31 (version=SSLv3 cipher=OTHER);
	Fri, 29 Apr 2011 00:10:32 -0700 (PDT)
Sender: Bernhard Schmidt <bschmidt@techwires.net>
From: Bernhard Schmidt <bschmidt@freebsd.org>
To: Kevin Lo <kevlo@freebsd.org>
Date: Fri, 29 Apr 2011 09:09:34 +0200
User-Agent: KMail/1.13.5 (Linux/2.6.32-31-generic; KDE/4.4.5; i686; ; )
References: <201104290628.p3T6SUV5086524@svn.freebsd.org>
In-Reply-To: <201104290628.p3T6SUV5086524@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201104290909.34920.bschmidt@freebsd.org>
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, Arthur Hartwig <a_hartwig@fastmaildot.fm>
Subject: Re: svn commit: r221199 - head/sys/dev/usb/wlan
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: bschmidt@freebsd.org
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Apr 2011 07:11:09 -0000

On Friday, April 29, 2011 08:28:30 Kevin Lo wrote:
> Author: kevlo
> Date: Fri Apr 29 06:28:29 2011
> New Revision: 221199
> URL: http://svn.freebsd.org/changeset/base/221199
> 
> Log:
>   Guard against default ni_chan
>   
>   PR: kern/144642
>   Submitted by: Arthur Hartwig <a_hartwig at fastmaildot fm>
> 
> Modified:
>   head/sys/dev/usb/wlan/if_rum.c

This seems about right, but.. did anyone ever verify that any beacons
get sent? and if so are the information included correct?

If the call fails due to the channel not yet being set, no further
attempt to setup the beacons are made. This might be quite harmless
for IBSS as long as other nodes are sending beacons. But for AP mode
it is rather critical. There also seem to be at least one missing
backcall, iv_update_beacon, this should ensure that beacons contain
updated information, eg. node's powersafe states. It can also be used
to ensure the beacon is setup.

Any takers? :)

-- 
Bernhard