From owner-svn-src-head@FreeBSD.ORG  Fri Dec 30 17:04:07 2011
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C54D9106566C;
	Fri, 30 Dec 2011 17:04:07 +0000 (UTC) (envelope-from scf@FreeBSD.org)
Received: from mail.farley.org (mail.farley.org
	[IPv6:2001:470:1f07:14d3:2::11])
	by mx1.freebsd.org (Postfix) with ESMTP id 7465C8FC18;
	Fri, 30 Dec 2011 17:04:07 +0000 (UTC)
Received: from thor.farley.org (HPooka@thor.farley.org
	[IPv6:2001:470:1f07:14d3:1::5])
	by mail.farley.org (8.14.5/8.14.5) with ESMTP id pBUH43E9042348;
	Fri, 30 Dec 2011 12:04:03 -0500 (EST) (envelope-from scf@FreeBSD.org)
Date: Fri, 30 Dec 2011 12:04:03 -0500 (EST)
From: "Sean C. Farley" <scf@FreeBSD.org>
To: Ed Schouten <ed@80386.nl>
In-Reply-To: <20111230090622.GO1895@hoeg.nl>
Message-ID: <alpine.BSF.2.02.1112301152260.4588@thor.farley.org>
References: <201112252015.pBPKFfZ1073959@svn.freebsd.org>
	<alpine.BSF.2.02.1112291617110.4588@thor.farley.org>
	<20111230090622.GO1895@hoeg.nl>
User-Agent: Alpine 2.02 (BSF 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Spam-Status: No, score=-1.5 required=4.0 tests=AWL,BAYES_00,SPF_SOFTFAIL
	autolearn=no version=3.3.2
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on mail.farley.org
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r228878 - head/include
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Dec 2011 17:04:07 -0000

On Fri, 30 Dec 2011, Ed Schouten wrote:

> Hello Sean,
>
> * Sean C. Farley <scf@FreeBSD.org>, 20111230 03:54:
>> I just thought of this while reviewing the change:  should
>> __bool_true_false_are_defined be set only if __cplusplus is not set?
>> It should be set for C99, but I wonder if it should be set for C++.
>
> Even if the C++ standard doesn't mention it at all, I think it doesn't
> mean it is forbidden to define it. It starts with __[a-z], so it is in
> the reserved namespace.

I am fine with it.  I found many variations of stdbool.h with some 
wrapping __bool_true_false_are_defined within the __cplusplus check 
(e.g., glibc) and some that did not.  glibc may have it because 
stdbool.h is included from cstdbool and stdbool.h in 
/usr/include/c++/4.2/tr1/.

>> Also, is there a style requirement that the guard for a header file
>> be based off of the name of the file?  I did not see anything obvious
>> for this within style(9), but I am curious.
>
> I am not aware of this.

I am not aware of it either, hence, my question.  It was just something 
to which I have grown accustomed.  Using __bool_true_false_are_defined 
as the guard works.

Sean
-- 
scf@FreeBSD.org