From owner-svn-src-all@freebsd.org Tue Jan 16 04:34:53 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CC989E73D77 for ; Tue, 16 Jan 2018 04:34:53 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-yb0-x22e.google.com (mail-yb0-x22e.google.com [IPv6:2607:f8b0:4002:c09::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8550D33C for ; Tue, 16 Jan 2018 04:34:53 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: by mail-yb0-x22e.google.com with SMTP id b18so6696733ybn.2 for ; Mon, 15 Jan 2018 20:34:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ShsvplN50YLlAM08Tn6yPuMBYgxk3vzuhGFdRBW5nPM=; b=MJVhzoiXxU27V4RCCg8uKRvW8YmB/bZ1a5+bWYv1hJwge5Cn/FqS7JN33lDL0yTgqy 3j3ur8FfXMC/nIf+04ZHT14cJ6VXgbtsysqUmFCg/h4IP97XRB520LfiyiSUP50Jvqpn SbRWgV455uEdANUuSDjAVe1y6RKY6ihAXM5b8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ShsvplN50YLlAM08Tn6yPuMBYgxk3vzuhGFdRBW5nPM=; b=YmAIDczv3rt+fvT5sQMlG/9R1FosBTWWiaMWUJ7fPyxe2jKOHxpyRJn8BzxyF/1fyV mF43GP5hprZw7L2pVjbtvHSIqzL0gz6yMv+cED5Ma5CfDwCh66piPQWmf4mAWpBBFpcQ gDgQGFGckeqFY9lHCd4Km/4XD6LvacbBf2ZGddzehpCjuc/gqWJ0yo4B+Jm3eryYz7Ux FuqKSHEusaPhB3585/20rPcpWCywJSv7kOGAsH9EhasWLtUhE7p4r7qR8tdQwWJb78cw Hc5isXu20AUqYC1YCl9ytbkCJa2tzR8Z7Lc7kXRTadKrI00qQFGCnnOxcsNa2iHCFITG QWjQ== X-Gm-Message-State: AKwxytf26z3jg7/PmOvSkjmMqsdgqvApoGDEa7FsGrJS6nECP1kYdqk6 3H3Q8pv/vqOpd4YBs57xvvAyWzMg6+N4aoJ3i7aO5Q== X-Google-Smtp-Source: ACJfBotIXeMmsVdBMLnTEI/RVuHQXKjCU5TvFXqPIpOhQ3seI4xph9siJIxS3h3gs+8fg5Ck6ZOIa2fISuExQYKSVt8= X-Received: by 10.37.107.82 with SMTP id o18mr1509478ybm.277.1516077292513; Mon, 15 Jan 2018 20:34:52 -0800 (PST) MIME-Version: 1.0 Received: by 10.37.46.79 with HTTP; Mon, 15 Jan 2018 20:34:21 -0800 (PST) In-Reply-To: References: <201801132230.w0DMUVmF081985@repo.freebsd.org> <7fe2a0bb-8592-75bc-6f58-cb77e2d6044c@FreeBSD.org> <20180114171448.GB89171@raichu> From: Eitan Adler Date: Mon, 15 Jan 2018 20:34:21 -0800 Message-ID: Subject: Re: svn commit: r327949 - in head/sys/dev: aacraid advansys ath beri/virtio bnxt bwn ciss cxgbe/crypto esp fb gpio if_ndis iwi kbd liquidio liquidio/base mpr mps mpt mrsas mxge netmap nvme pst ral rp s... To: Warner Losh Cc: Mark Johnston , svn-src-head@freebsd.org, svn-src-all@freebsd.org, Pedro Giffuni , src-committers Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jan 2018 04:34:53 -0000 On 14 January 2018 at 12:16, Warner Losh wrote: > On Jan 14, 2018 10:15 AM, "Mark Johnston" wrote: > > On Sat, Jan 13, 2018 at 05:34:24PM -0500, Pedro Giffuni wrote: > > > > > > On 01/13/18 17:30, Pedro F. Giffuni wrote: > > > Author: pfg > > > Date: Sat Jan 13 22:30:30 2018 > > > New Revision: 327949 > > > URL: https://svnweb.freebsd.org/changeset/base/327949 > > > > > > Log: > > > dev: make some use of mallocarray(9). > > > > > > Focus on code where we are doing multiplications within malloc(9). > None of > > > these is likely to overflow, however the change is still useful as > some > > > static checkers can benefit from the allocation attributes we use > for > > > mallocarray. > > > > > > This initial sweep only covers malloc(9) calls with M_NOWAIT. No > good > > > reason but I started doing the changes before r327796 and at that > time it > > > was convenient to make sure the sorrounding code could handle NULL > values. > > > > > For the record, this was part of > > > > https://reviews.freebsd.org/D13837 > > > > I didn't mention it in the commit log because I am not ready to close > > the revision yet. > > Some developers have been using the "X-Differential revision:" tag in > this case. > > > I just list it per normal, but reopen the review if I need to. > If you keep the D#### in the message, phabricator will add a connection to the commit, even if you don't include the full "Differential Revision' line. -- Eitan Adler