From owner-svn-src-all@freebsd.org Tue Aug 18 08:48:27 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 789BF3B4322; Tue, 18 Aug 2020 08:48:27 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4BW4Ly6zDKz3SwG; Tue, 18 Aug 2020 08:48:26 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 07I8mJKV014050 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Tue, 18 Aug 2020 11:48:22 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 07I8mJKV014050 Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 07I8mJiB014049; Tue, 18 Aug 2020 11:48:19 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 18 Aug 2020 11:48:19 +0300 From: Konstantin Belousov To: Peter Grehan Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r364340 - in head/sys/amd64: include vmm vmm/intel Message-ID: <20200818084819.GN2551@kib.kiev.ua> References: <202008180723.07I7NlVq046197@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202008180723.07I7NlVq046197@repo.freebsd.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on tom.home X-Rspamd-Queue-Id: 4BW4Ly6zDKz3SwG X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2020 08:48:27 -0000 On Tue, Aug 18, 2020 at 07:23:47AM +0000, Peter Grehan wrote: > +void > +vmx_msr_guest_exit_tsc_aux(struct vmx *vmx, int vcpuid) > +{ > + uint64_t guest_tsc_aux = vmx->guest_msrs[vcpuid][IDX_MSR_TSC_AUX]; > + uint32_t cpuid = PCPU_GET(cpuid); > + > + if (vmx_have_msr_tsc_aux(vmx) && (guest_tsc_aux != cpuid)) This is quite unobvious place to look at if host TSC_AUX is ever going to provide something different from cpuid. Could you please add a comment at {i386/i386,amd64/amd64}/initcpu.c::initializecpu() around TSC_AUX settings pointing out this code ?