Date: Tue, 18 Aug 2020 11:48:19 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Peter Grehan <grehan@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r364340 - in head/sys/amd64: include vmm vmm/intel Message-ID: <20200818084819.GN2551@kib.kiev.ua> In-Reply-To: <202008180723.07I7NlVq046197@repo.freebsd.org> References: <202008180723.07I7NlVq046197@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Aug 18, 2020 at 07:23:47AM +0000, Peter Grehan wrote:
> +void
> +vmx_msr_guest_exit_tsc_aux(struct vmx *vmx, int vcpuid)
> +{
> + uint64_t guest_tsc_aux = vmx->guest_msrs[vcpuid][IDX_MSR_TSC_AUX];
> + uint32_t cpuid = PCPU_GET(cpuid);
> +
> + if (vmx_have_msr_tsc_aux(vmx) && (guest_tsc_aux != cpuid))
This is quite unobvious place to look at if host TSC_AUX is ever going
to provide something different from cpuid.
Could you please add a comment at
{i386/i386,amd64/amd64}/initcpu.c::initializecpu() around TSC_AUX
settings pointing out this code ?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200818084819.GN2551>